Add Autodll plugin and DllReferencePlugin capability #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moos
commented
Feb 5, 2018
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "name": "custom-react-scripts", | |||
There was a problem hiding this comment.
This was needed for linklocal to work.
moos
commented
Feb 5, 2018
| @@ -5,7 +5,9 @@ module.exports = function mapObject(obj, fn, toArray) { | |||
| return final; | |||
| } | |||
| if (toArray) { | |||
| final.push(result); | |||
| Array.isArray(result) | |||
There was a problem hiding this comment.
dll reference returns an array - need to merge rather than push.
moos
commented
Feb 5, 2018
| @@ -288,6 +288,7 @@ module.exports = { | |||
| // https://github.com/jmblog/how-to-optimize-momentjs-with-webpack | |||
| // You can remove this if you don't use Moment.js: | |||
| new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/), | |||
| ...customConfig.webpackPlugins, | |||
There was a problem hiding this comment.
dlls are obviously needed for prod builds - so include here. Individual features can disable themselves via the isDev parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables DLL generation using the new autodll-webpack-plugin - implementation is similar to this PR facebook#2710.
I've also added a way to consume DLLs (from autodll or from other repos).