Uses new cd context manager more
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds logging as we change directories.
|
I'm drafting a PR (kivy-ios package) that would make other PRs conflict, so I prefer to merge the PR I'm sure about. Also I already got an implicit approval from @Zen-CODE via #462 (comment) 😄 |
|
A little late but yes, I think this is indeed a great approach to run commands that need a change of current working directory. +1 |
|
Thanks for the feedback, it was rushing a bit for some of the changes as I'm moving things around to create the package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds logging as we change directories.
Note that I could only apply it to very few recipes so far as
rebuild_updated_recipes.pywas failing with some of our broken recipes