Plyer audio for android with facade and example #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Used for recording audio. | ||
| Use method `start` to start record and `stop` for stop recording. | ||
| For hear, what you have just recorded use method `play`. |
There was a problem hiding this comment.
nit: "To hear " (no comma). But a comma would be nice after "recorded".
|
This looks nice overall, i have minor issues with documentation, but the rest is ok. About codecs, i agree it's a complex problem, i think the best we could do would be to offer another api to return available codecs so the programmer can look if their favorite one is in the list, a bit like the result of |
|
👍 |
dessant
added a commit
that referenced
this pull request
May 16, 2015
Plyer audio for android with facade and example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recently I finished with audio recording for android. It works for android Api>=9.
Please check it out!
best regards