Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send sms android api fix #271

Closed
wants to merge 6 commits into from
Closed

Conversation

sumitmadhwani
Copy link
Contributor

Fixes issue #261
Current android sms api in plyer uses sms manager api to send sms. I have tried to use intent class which uses built-in sms app of device to send sms.
Any suggestions are welcomed otherwise it is ready to be merged.

@sumitmadhwani sumitmadhwani changed the title Send sms api fix Send sms android api fix Jan 22, 2017
@sumitmadhwani
Copy link
Contributor Author

screenshot_20170123-053603

After pressing Send SMS button,

screenshot_20170123-053630

@akshayaurora
Copy link
Member

Original implementation works, just tested it yesterday on multiple mobiles in a work shop 10+ mobiles with 0 issues.

Feel free to open a new one, adding option launch_interface defaulting to 0 preserving old behavior

@akshayaurora
Copy link
Member

@Malverick thanks for all the work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants