-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Linux email support #47
Conversation
uri += "?" if not "?" in uri else "&" | ||
uri += "body=" | ||
uri += quote(str(text)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may notice that there's no else: I tested it and it works anyways, it should just open the email client. It worked with Thunderbird.
I have created #50 for MacOS based on this! |
We had some discussion on using xdg-email for this, though my version seems buggy so I never got to the bottom of it. The advantage would be that the pre-existing tool is able to properly handle the details of the uri spec, including edge cases. I don't know if it matters, but it still might be a neater solution. |
Well, all the email clients are supposed to support mailto links, including the web browser based ones (GMail and Roundcube do AFAIK). xdg-open shouldn't be a problem. |
@Davideddu What was the reason behind reverting back the xdg-email change? |
@trivedigaurav it had some bugs when using non-ASCII characters that could early be escaped with xdg-open, mailto and urllib.quote. |
Thanks @Davideddu. It looks like xdg-open works better than xdg-email then. @inclement Do you still have any concerns about using this? |
No description provided.