Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Linux email support #47

Merged
merged 3 commits into from
Jun 24, 2014
Merged

added Linux email support #47

merged 3 commits into from
Jun 24, 2014

Conversation

depau
Copy link
Contributor

@depau depau commented Apr 2, 2014

No description provided.

uri += "?" if not "?" in uri else "&"
uri += "body="
uri += quote(str(text))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may notice that there's no else: I tested it and it works anyways, it should just open the email client. It worked with Thunderbird.

@trivedigaurav
Copy link
Member

I have created #50 for MacOS based on this!

@inclement
Copy link
Member

We had some discussion on using xdg-email for this, though my version seems buggy so I never got to the bottom of it. The advantage would be that the pre-existing tool is able to properly handle the details of the uri spec, including edge cases.

I don't know if it matters, but it still might be a neater solution.

@depau
Copy link
Contributor Author

depau commented Apr 3, 2014

Well, all the email clients are supposed to support mailto links, including the web browser based ones (GMail and Roundcube do AFAIK). xdg-open shouldn't be a problem.

@trivedigaurav
Copy link
Member

@Davideddu What was the reason behind reverting back the xdg-email change?

@depau
Copy link
Contributor Author

depau commented May 6, 2014

@trivedigaurav it had some bugs when using non-ASCII characters that could early be escaped with xdg-open, mailto and urllib.quote.

@trivedigaurav
Copy link
Member

Thanks @Davideddu. It looks like xdg-open works better than xdg-email then.

@inclement Do you still have any concerns about using this?

tito added a commit that referenced this pull request Jun 24, 2014
@tito tito merged commit 861e756 into kivy:master Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants