Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cffi] Updated recipe to last cffi version (1.11.5) #1441

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

goffi-contrib
Copy link
Contributor

No description provided.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why chaning the url string?

pythonforandroid/recipes/cffi/__init__.py Outdated Show resolved Hide resolved
@AndreMiras
Copy link
Member

Thanks for updating the changes.
The conditional build seems to be failing and the error is still unclear to me.
I've started it again, let's see. If it's still failing I'd like to investigate a bit more. Maybe it would be another excuse to improve our CI tools.
In the meantime, do you know you can "override" the version without touching the recipe? All you need to do is specify it with ==version just like when you pip install a package.

@goffi-contrib
Copy link
Contributor Author

@AndreMiras no, I didn't know. Thanks for the tip.
About the error, it smells like an incomplete docker image, autotools seem to be missing.

@AndreMiras
Copy link
Member

Good catch for the autotools, the error was in the middle of nowhere 👍
So note for me later.

android/build/other_builds/libffi/armeabi/libffi/autogen.sh: 2: exec: autoreconf: not found
...
Traceback (most recent call last):

  File "setup_testapp_python2.py", line 30, in <module>

    package_data={'testapp': ['*.py', '*.png']}

  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup

    dist.run_commands()

  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands

    self.run_command(cmd)

  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command

    cmd_obj.run()

  File "/home/user/pythonforandroid/bdistapk.py", line 81, in run

    main()

  File "/home/user/pythonforandroid/toolchain.py", line 999, in main

    ToolchainCL()

  File "/home/user/pythonforandroid/toolchain.py", line 532, in __init__

    getattr(self, args.subparser_name.replace('-', '_'))(args)

  File "/home/user/pythonforandroid/toolchain.py", line 145, in wrapper_func

    build_dist_from_args(ctx, dist, args)

  File "/home/user/pythonforandroid/toolchain.py", line 189, in build_dist_from_args

    build_recipes(build_order, python_modules, ctx)

  File "/home/user/pythonforandroid/build.py", line 580, in build_recipes

    recipe.build_arch(arch)

  File "/home/user/pythonforandroid/recipes/libffi/__init__.py", line 37, in build_arch

    shprint(sh.Command('./autogen.sh'), _env=env)

  File "/home/user/pythonforandroid/logger.py", line 176, in shprint

    for line in output:

  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 863, in next

    self.wait()

  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 792, in wait

    self.handle_command_exit_code(exit_code)

  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 815, in handle_command_exit_code

    raise exc

sh.ErrorReturnCode_127: 



  RAN: /home/user/.local/share/python-for-android/build/other_builds/libffi/armeabi/libffi/autogen.sh



  STDOUT:

/home/user/.local/share/python-for-android/build/other_builds/libffi/armeabi/libffi/autogen.sh: 2: exec: autoreconf: not found





  STDERR:



Traceback (most recent call last):
  File "./ci/rebuild_updated_recipes.py", line 100, in <module>
    main()
  File "./ci/rebuild_updated_recipes.py", line 96, in main
    build(target_python, recipes)
  File "./ci/rebuild_updated_recipes.py", line 72, in build
    requirements, _err_to_out=True, _iter=True):
  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 863, in next
    self.wait()
  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 792, in wait
    self.handle_command_exit_code(exit_code)
  File "/home/user/venv/local/lib/python2.7/site-packages/sh.py", line 815, in handle_command_exit_code
    raise exc
sh.ErrorReturnCode_1: 

  RAN: /home/user/venv/bin/python setup_testapp_python2.py apk --sdk-dir /opt/android/android-sdk --ndk-dir /opt/android/android-ndk --bootstrap sdl2 --requirements cffi,python2
...

Which reminds me, that I wanted to discuss with the team of some optional ways to handle system dependencies.

@goffi-contrib
Copy link
Contributor Author

@AndreMiras I think this recipe should be added to BROKEN_RECIPES_PYTHON2 (same as #1440 (comment)), but I wait for the other to be merged first, to avoid conflict.

@AndreMiras
Copy link
Member

Yes indeed go for it since #1440 was just merged.
Please add a comment just like we did for protobuf_cpp so we know why this is listed as broken.
Thanks for all your contributions 🍻

@goffi-contrib
Copy link
Contributor Author

@AndreMiras done

@AndreMiras AndreMiras merged commit 5382dc0 into kivy:master Nov 10, 2018
@AndreMiras
Copy link
Member

Merged! And thanks for always squashing your commits, really appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants