-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added python3 testapp build to Travis matrix #1456
Conversation
All the tests are consistently failing to unzip downloaded things. |
It could be pypi, when I try from my shell I get a 503:
Edit: Edit2: aaaand it's back! |
Okay, so the python3 recipe has errors like:
(full log) Interestingly, the Python 2 PyThreadState does have these members, which makes me suspect a cython version problem. @tito I remember you had problems using cython2 with the python3 recipe, did you get errors like this? |
cython/cython#1978 <- confirmed the issue is cython version related. I'm not clear if just upgrading the cython version will work, but we'll see. |
Great catch. I'm actually updating cython to 0.28.6 in an upcoming pull request #1457 |
Testing 0.29 here because that's what I have working locally. If 0.28.6 works too then that would obviously also be fine, but I found some indications that at least some versions of 0.28 still had this problem. |
By the way keep in mind you can always run your tests directly on the Docker environment to make debugging faster than via Travis.
|
Thanks, I was going to ask how to do that, although I was also hoping that upgrading cython would just work and leave me to look at more interesting things. |
627d6ca
to
6303a70
Compare
ad6104c
to
8930e78
Compare
The python3 build worked, so I squashed the experimental commits and will let the tests pass again (as they all should now). When that happens, this is good to merge. |
@@ -93,7 +93,7 @@ RUN useradd --create-home --shell /bin/bash ${USER} | |||
# with sudo access and no password | |||
RUN usermod -append --groups sudo ${USER} | |||
RUN echo "%sudo ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers | |||
RUN pip install --quiet --upgrade Cython==0.28.6 | |||
RUN pip install --quiet --upgrade cython==0.28.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, why changing the case, it just create "noise" in the history?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't, you did, and I rebased on your changes :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19d2de0#diff-3254677a7917c6c01f55212f86c57fbfR96
In my changes it's with a capital plus the version change. In your changes you're only updating the case.
It's minor anyway, but I think it could be avoided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I omitted this from the original PR because the Travis build failed at pyjnius for some reason. Trying again here to debug it.