Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python3 testapp build to Travis matrix #1456

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

inclement
Copy link
Member

I omitted this from the original PR because the Travis build failed at pyjnius for some reason. Trying again here to debug it.

@inclement inclement mentioned this pull request Nov 10, 2018
6 tasks
@inclement
Copy link
Member Author

All the tests are consistently failing to unzip downloaded things.

@AndreMiras
Copy link
Member

AndreMiras commented Nov 10, 2018

It could be pypi, when I try from my shell I get a 503:

wget https://pypi.python.org/packages/source/s/setuptools/setuptools-40.0.0.zip
--2018-11-10 19:22:52--  https://pypi.python.org/packages/source/s/setuptools/setuptools-40.0.0.zip
wget: /home/andre/.netrc:4: unknown token "method"
wget: /home/andre/.netrc:4: unknown token "interactive"
Resolving pypi.python.org (pypi.python.org)... 151.101.132.223, 2a04:4e42:1f::223
Connecting to pypi.python.org (pypi.python.org)|151.101.132.223|:443... connected.
HTTP request sent, awaiting response... 301 Redirect to Primary Domain
Location: https://pypi.org/packages/source/s/setuptools/setuptools-40.0.0.zip [following]
--2018-11-10 19:22:52--  https://pypi.org/packages/source/s/setuptools/setuptools-40.0.0.zip
Resolving pypi.org (pypi.org)... 151.101.128.223, 151.101.0.223, 151.101.192.223, ...
Connecting to pypi.org (pypi.org)|151.101.128.223|:443... connected.
HTTP request sent, awaiting response... 503 Backend is unhealthy
2018-11-10 19:22:57 ERROR 503: Backend is unhealthy.

Edit:
However that one works: https://files.pythonhosted.org/packages/d3/3e/1d74cdcb393b68ab9ee18d78c11ae6df8447099f55fe86ee842f9c5b166c/setuptools-40.0.0.zip
So it could be that our short url version we were always using is not working anymore, right?

Edit2: aaaand it's back!

@inclement
Copy link
Member Author

Okay, so the python3 recipe has errors like:

      working: jnius/jnius.c:46896:11: error: 'PyThreadState' has no member named 'exc_type'  
       working:      tstate->exc_type = local_type;                                            
       working:            ^                                                                   
       working: jnius/jnius.c:46897:11: error: 'PyThreadState' has no member named 'exc_value' 
       working:      tstate->exc_value = local_value;                                          

(full log)

Interestingly, the Python 2 PyThreadState does have these members, which makes me suspect a cython version problem. @tito I remember you had problems using cython2 with the python3 recipe, did you get errors like this?

@inclement
Copy link
Member Author

cython/cython#1978 <- confirmed the issue is cython version related. I'm not clear if just upgrading the cython version will work, but we'll see.

@AndreMiras
Copy link
Member

Great catch. I'm actually updating cython to 0.28.6 in an upcoming pull request #1457

@inclement
Copy link
Member Author

Testing 0.29 here because that's what I have working locally. If 0.28.6 works too then that would obviously also be fine, but I found some indications that at least some versions of 0.28 still had this problem.

@AndreMiras
Copy link
Member

By the way keep in mind you can always run your tests directly on the Docker environment to make debugging faster than via Travis.
So basically to play with this you can:

  1. build the image: docker build --tag=p4a .
  2. run it in an interactive shell docker run -it --rm p4a
  3. prepare your env from this shell e.g. pip install cython==0.29
  4. and play with p4a just like we have it in Travis e.g. python setup_testapp_python3.py apk...

@inclement
Copy link
Member Author

Thanks, I was going to ask how to do that, although I was also hoping that upgrading cython would just work and leave me to look at more interesting things.

@inclement inclement force-pushed the python3_testapp_travis branch from 627d6ca to 6303a70 Compare November 10, 2018 23:11
@inclement inclement force-pushed the python3_testapp_travis branch from ad6104c to 8930e78 Compare November 10, 2018 23:49
@inclement
Copy link
Member Author

The python3 build worked, so I squashed the experimental commits and will let the tests pass again (as they all should now). When that happens, this is good to merge.

@@ -93,7 +93,7 @@ RUN useradd --create-home --shell /bin/bash ${USER}
# with sudo access and no password
RUN usermod -append --groups sudo ${USER}
RUN echo "%sudo ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers
RUN pip install --quiet --upgrade Cython==0.28.6
RUN pip install --quiet --upgrade cython==0.28.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, why changing the case, it just create "noise" in the history?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't, you did, and I rebased on your changes :p

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19d2de0#diff-3254677a7917c6c01f55212f86c57fbfR96
In my changes it's with a capital plus the version change. In your changes you're only updating the case.
It's minor anyway, but I think it could be avoided

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inclement inclement merged commit fbab95d into kivy:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants