Add ctypes support for python3's recipe #1465
Conversation
There was a problem hiding this comment.
Looking very good thanks!
FYI, rather than creating a new PR. You could have amend/squash your changes of #1463 and push force to your branch. That way we keep the review history on a single PR.
I do know @AndreMiras, but I though that it was not recommended to force push to public repos and (I usually give administrators access to all my prs...but honestly...I don't know how far goes that git feature)... that is why I proceed this way...it seemed easier to me at that moment to create a new pr because I already had a new branch with the recipe cleaned up, anyway, what commands do you use to amend/squash? |
|
i usually use but it's not a big deal, we can also squash on merge through the interface if we want to. |
|
More practical option is then or some fixes before, depending on what git status tells you. There are explicit options for squashing into one commit, editing + squashing and many more. Just open the documenation :) For an ordinary rebase to pull your commits on the |
|
Nope you don't need specific access since you do it on your fork, but it still update the PR. |
|
¡¡¡Many thanks guys, for all the instructions, you pointed me to the right direction!!! I was investigating the rebase command and I found this tutorial that clarifies all the commands mentioned: https://www.atlassian.com/git/tutorials/merging-vs-rebasing Ahhh...and very sorry "about the the review history" 😅..this will not happen anymore 💪 |
Should be mentioned that the current test app for python3 has been modified by adding libffi to the requirements because the ui for the app has some button to test the ctypes module.
opacam
force-pushed
the
python3-ctypes-support
branch
from
01e7716 to
0fec438
Compare
Actions taken:
- I found that a lot of basic python modules get not compiled. Here we solve that issue by creating a patch (fix-missing-extensions.patch) adapted from the one applied to the python3's master branch. This new patch replaces the "fix-modules-initialization" (which worked but not compiled the necessary modules into .so files). Now all the needed modules should be present.
* Note: **Should be mentioned that the ctypes module builds without a problem for python2 (no need to link with custom libffi as we do in python 3 in pr kivy#1465)**
- I reviewed all the patches to move all the unneeded into a sub folder (maybe we can need some of them...)
* Note: all the patches where made to be applied into the old python2's build system, and only those which allows the native build to succeed and the ones which fix python initialization should be needed with the new build system
- Rename patches to be clear and to remove some upper cases and versions (we will not have many more future versions for python2 and I think that removing this versions make the code more readable)
Actions taken:
- I found that a lot of basic python modules get not compiled. Here we solve that issue by creating a patch (fix-missing-extensions.patch) adapted from the one applied to the python3's master branch. This new patch replaces the "fix-modules-initialization" (which worked but not compiled the necessary modules into .so files). Now all the needed modules should be present.
* Note: **Should be mentioned that the ctypes module builds without a problem for python2 (no need to link with custom libffi as we do in python 3 in pr kivy#1465)**
- I reviewed all the patches to move all the unneeded into a sub folder (maybe we can need some of them...)
* Note: all the patches where made to be applied into the old python2's build system, and only those which allows the native build to succeed and the ones which fix python initialization should be needed with the new build system
- Rename patches to be clear and to remove some upper cases and versions (we will not have many more future versions for python2 and I think that removing this versions make the code more readable)
Actions taken:
- I found that a lot of basic python modules get not compiled. Here we solve that issue by creating a patch (fix-missing-extensions.patch) adapted from the one applied to the python3's master branch. This new patch replaces the "fix-modules-initialization" (which worked but not compiled the necessary modules into .so files). Now all the needed modules should be present.
* Note: **Should be mentioned that the ctypes module builds without a problem for python2 (no need to link with custom libffi as we do in python 3 in pr kivy#1465)**
- I reviewed all the patches to move all the unneeded into a sub folder (maybe we can need some of them...)
* Note: all the patches where made to be applied into the old python2's build system, and only those which allows the native build to succeed and the ones which fix python initialization should be needed with the new build system
- Rename patches to be clear and to remove some upper cases and versions (we will not have many more future versions for python2 and I think that removing this versions make the code more readable)
|
Closing as merged in #1463. Thanks again! Edit: it looks like the doc was omitted from that PR, did you want to merge that here? |
|
Actually I misread the other issue, so merging instead :) Thanks! |
Should be mentioned that the current test app for python3 has been modified by adding libffi to the requirements because the ui for the app has some button to test the ctypes module.
Note: This is the pull request #1463 cleaned up, with documentation and with the commits squashed into one single commit