Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doubleratchet] removed this recipe #1762

Merged
merged 1 commit into from
Mar 17, 2019
Merged

[doubleratchet] removed this recipe #1762

merged 1 commit into from
Mar 17, 2019

Conversation

goffi-contrib
Copy link
Contributor

No description provided.

AndreMiras
AndreMiras reviewed Mar 16, 2019
View reviewed changes
pythonforandroid/recipes/doubleratchet/__init__.py Outdated
@@ -3,7 +3,7 @@

class DoubleRatchetRecipe(PythonRecipe):
name = 'doubleratchet'
version = '0.4.0'
version = '0.6.0'
url = 'https://pypi.python.org/packages/source/D/DoubleRatchet/DoubleRatchet-{version}.tar.gz'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did experience the issue you're talking about regarding the slow download on that package.
Maybe we want to give a try to the github release instead.
https://github.com/Syndace/python-doubleratchet/archive/v0.6.0-beta.tar.gz
What do you think?
Otherwise that won't probably compile in our CI, so you could add it to the list of "broken recipe" here? https://github.com/kivy/python-for-android/blob/6c31e10/ci/constants.py

@AndreMiras AndreMiras self-assigned this Mar 16, 2019
@goffi-contrib
[doubleratchet] removed the recipe
d842927 
DoubleRatchet is a pure Python module and it can be installed without recipe.
@goffi-contrib goffi-contrib force-pushed the doubleratchet_update_0.6.0 branch from f925714 to d842927 Compare March 17, 2019 16:18
@goffi-contrib
Copy link
Contributor Author

goffi-contrib commented Mar 17, 2019 •
edited
Loading

@AndreMiras I've been testing without the recipe, it's working (DoubleRatchet is pure python module).

I've tried to remove omemo-bakend-signal too, but when it's installed as pure python, dependencies are not installed correctly (notably DoubleRatchet is not present in the final distribution).

So I've updated this PR to remove entirely doubleratchet recipe.

@goffi-contrib goffi-contrib changed the title [doubleratchet] updated to 0.6.0 [doubleratchet] removed this recipe Mar 17, 2019
AndreMiras
AndreMiras approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less is more, thanks 👏

@AndreMiras AndreMiras merged commit 5e43b42 into kivy:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees

@AndreMiras AndreMiras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goffi-contrib @AndreMiras