Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically load/enable certifi in kivy #2055

Merged
merged 1 commit into from
Jan 24, 2020
Merged

automatically load/enable certifi in kivy #2055

merged 1 commit into from
Jan 24, 2020

Conversation

tshirtman
Copy link
Member

fix #1827

@tshirtman tshirtman mentioned this pull request Jan 23, 2020
Merged
@tshirtman tshirtman requested a review from inclement January 24, 2020 00:37
inclement
inclement reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in python_depends rather than depends? I think that would be correct if it's something to install with pip.

@tshirtman
Copy link
Member Author

Should this be in python_depends rather than depends? I think that would be correct if it's something to install with pip.

indeed I forgot about python_depends, and yes it's pure python, so that would be better, will fix.

@tshirtman tshirtman merged commit f771ccb into develop Jan 24, 2020
@tshirtman tshirtman deleted the fix_1827 branch January 24, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclement inclement inclement approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use AsyncImage with HTTPS URL (or any HTTPS url wit any request): fix is to manually load certifi
2 participants
@tshirtman @inclement