Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes gevent recipe on arm64-v8a arch #2093

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fixes gevent recipe on arm64-v8a arch #2093

merged 1 commit into from
Mar 23, 2020

Conversation

AndreMiras
Copy link
Member

Adding libm.so to the arm64-v8a build fixes undefined reference
errors. The (truncated) config.log errors were:

...
libpython3.7m.so: undefined reference to `hypot@LIBC'
libpython3.7m.so: undefined reference to `frexp@LIBC'
libpython3.7m.so: undefined reference to `cos@LIBC'
libpython3.7m.so: undefined reference to `pow@LIBC'
libpython3.7m.so: undefined reference to `atan2@LIBC'
libpython3.7m.so: undefined reference to `modf@LIBC'
libpython3.7m.so: undefined reference to `exp@LIBC'
libpython3.7m.so: undefined reference to `sin@LIBC'
libpython3.7m.so: undefined reference to `log@LIBC'
libpython3.7m.so: undefined reference to `fmod@LIBC'
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
...

Refs: #1722 (comment)

@AndreMiras
Fixes gevent recipe on arm64-v8a arch
56a92b1 
Adding `libm.so` to the `arm64-v8a` build fixes undefined reference
errors. The (truncated) config.log errors were:
```
...
libpython3.7m.so: undefined reference to `hypot@LIBC'
libpython3.7m.so: undefined reference to `frexp@LIBC'
libpython3.7m.so: undefined reference to `cos@LIBC'
libpython3.7m.so: undefined reference to `pow@LIBC'
libpython3.7m.so: undefined reference to `atan2@LIBC'
libpython3.7m.so: undefined reference to `modf@LIBC'
libpython3.7m.so: undefined reference to `exp@LIBC'
libpython3.7m.so: undefined reference to `sin@LIBC'
libpython3.7m.so: undefined reference to `log@LIBC'
libpython3.7m.so: undefined reference to `fmod@LIBC'
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
...
```
Refs: kivy#1722 (comment)
@AndreMiras AndreMiras force-pushed the feature/fix_gevent_arm64-v8a_build branch from 7757f8f to 56a92b1 Compare March 22, 2020 21:16
@AndreMiras AndreMiras requested a review from opacam March 22, 2020 21:51
opacam
opacam approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks!!

@AndreMiras AndreMiras merged commit 21d4d35 into kivy:develop Mar 23, 2020
@AndreMiras AndreMiras deleted the feature/fix_gevent_arm64-v8a_build branch March 23, 2020 13:17
@AndreMiras AndreMiras mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @opacam