Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add pandas recipe #2100

Merged
merged 4 commits into from
Mar 25, 2020
Merged

✨ Add pandas recipe #2100

merged 4 commits into from
Mar 25, 2020

Conversation

opacam
Copy link
Member

@opacam opacam commented Mar 25, 2020

Notes:

Since we manage `pandas`'s dependencies from the recipe,
we remove them from `setup.py` because it causes an error when we run
our `CI` tests.
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.
I've restarted the python2 build that was failing on pyjnuis patching.
I see it's in the conflicts list but at least it should not fail while patching

@AndreMiras
Copy link
Member

Build is now green

@opacam
Copy link
Member Author

opacam commented Mar 25, 2020

@AndreMiras, Thanks to restart the build and the approval!! 😄

Let's merge the pandas recipe now 🎉

@opacam opacam merged commit f91d080 into kivy:develop Mar 25, 2020
@inclement
Copy link
Member

Didn't see this PR at the time, but seeing the message in the log was a nice surprise - awesome work!

zworkb pushed a commit to zworkb/python-for-android that referenced this pull request Apr 15, 2020
* ✨ Add `pandas` recipe

* ✅ Add tests for `pandas` recipe

* ⬆️ Update `pandas` to latest version `v1.0.3`

* 💚 Remove `pandas`'s dependencies from `setup.py`

Since we manage `pandas`'s dependencies from the recipe,
we remove them from `setup.py` because it causes an error when we run
our `CI` tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants