PythonActivityUtil helper for unpacking data #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the artifacts for adb logcat |
|
Thank you for checking @opacam so I could eventually break it 🎉 😄 |
|
Incredible I've tested both artifacts and they are working on my device 🤔 I'll try to understand what's going on by looking at your stacktrace. |
|
I will try again, it could be a transfer issue with my phone |
|
That seems very unlikely to be a transfer issue to me. The stacktrace you shared is close to things I've touched so it could really be a regression on certain device. If you can reproduce on this PR, could you also check if current develop testapps are also crashing or if it's just this pull request? |
|
Yea, I will try with latest artifact of develop branch... BTW, the same error: For the record: I tested with Android 10 device |
|
Develop is working, tested |
|
OK thank you good to know it's only this PR and develop is still OK. |
|
No problem, ping me when you need me 😉 |
|
Great I could reproduce on another device! |
AndreMiras
force-pushed
the
feature/share_unpack_data_java_code
branch
from
e486766 to
dfea735
Compare
|
Got a working fix I think, but linting errors started popping. |
This helper class shares code to be reused between the `PythonActivity` classes of the different bootstraps. Also adds few minor adjustments to existing classes.
AndreMiras
force-pushed
the
feature/share_unpack_data_java_code
branch
from
dfea735 to
5312595
Compare
opacam
approved these changes
May 12, 2020
lerela
added a commit
to chronolife-rd/python-for-android
that referenced
this pull request
Jun 23, 2020
🔖 v2020.06.02 * Adds missing requests sub dependencies (kivy#2221) * Bumps to Gradle 6.4.1 (kivy#2222) * Bumps to Cython==0.29.19 (kivy#2220) * Updates install and troubleshooting docs (kivy#2219) * Bumps to Ubuntu 20.04 (kivy#2218) * Attempt to improve the issue template (kivy#2217) * Add `opencv_extras` recipe (kivy#2209) * Split logic for build modes & debug symbols (kivy#2213) * Troubleshoot SSL error (kivy#2205) * Remove superfluous recipes fixes (kivy#2202) * Add tests for hostpython3 recipe (kivy#2196) * Fix for 'cannot find setuptools module' (kivy#2195) * Rename `Hostpython3Recipe` class to camel case (kivy#2194) * Fix `test_should_build` (kivy#2193) * Add initial tests for python3 recipe (kivy#2192) * PythonActivityUtil helper for unpacking data (kivy#2189) * Fixes flake8 errors post update (kivy#2191) * Share PythonUtil.java between bootstraps (kivy#2188) * Java code linting using PMD 6.23.0 (kivy#2187) * Deletes deprecated renpy Python{Activity,Service}.java (kivy#2186) * Removes java concurrency/ folder (kivy#2185) * Reuse common AssetExtract.java (kivy#2182) * Use common Hardware.java (kivy#2183) * Moves kamranzafar/ java directory to common/ (kivy#2184) * Updates release documentation (kivy#2177) * Fixes service only unittest loading (kivy#2181) * Narrows some context manager scopes (kivy#2179) * Downgrades to SDL2 2.0.9 (kivy#2180) * Bump to SDL2 2.0.10 & extract .java from SDL2 tarball (kivy#2113) * Adds pygame recipe (kivy#2164) * Adds macOS install instructions (2165) * Removed python2 support mention from README (kivy#2162) * Adding more assets (kivy#2132) * Get --add-source working for dirs in Gradle builds (kivy#2156) * Fixes python build with macOS venv (kivy#2159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper class shares code to be reused between the
PythonActivityclasses of the different bootstraps.
Also adds few minor adjustments to existing classes.