Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added few input parameters to make possible to use custom java classes and tweak AndroidManifest.xml #2338

Merged
merged 1 commit into from
Feb 14, 2021
Merged

added few input parameters to make possible to use custom java classes and tweak AndroidManifest.xml #2338

merged 1 commit into from
Feb 14, 2021

Conversation

vesellov
Copy link
Contributor

No description provided.

@vesellov vesellov force-pushed the develop branch 2 times, most recently from 5c1f607 to 98a9fe6 Compare October 19, 2020 09:56
@vesellov
Copy link
Contributor Author

vesellov commented Oct 19, 2020 •
edited
Loading

Hello guys.... this is the second part of the change I did a while ago in another PR : #2248

Now I am also adding option to specify custom PythonService.java class in case you need to tweak it. For example in my app I need to add additional code to onDestroy() method and that I am not able to do without redefining the java class... once that is merged I will start already prepared PR for buildozer repo... started: kivy/buildozer#1275

@vesellov vesellov force-pushed the develop branch 2 times, most recently from 79175a1 to 471422a Compare October 19, 2020 11:25
@vesellov vesellov mentioned this pull request Oct 22, 2020
Open
@vesellov vesellov marked this pull request as draft October 30, 2020 12:17
@vesellov vesellov marked this pull request as ready for review October 30, 2020 12:17
@vesellov vesellov force-pushed the develop branch 2 times, most recently from 022577d to 030b57e Compare January 9, 2021 10:08
@vesellov vesellov mentioned this pull request Jan 9, 2021
Merged
@vesellov
Copy link
Contributor Author

Can someone please review? this is a very useful feature for those who requires deep customization of .java classes

@vesellov vesellov force-pushed the develop branch 2 times, most recently from 07b2280 to 7f407b5 Compare February 10, 2021 12:49
@vesellov
Copy link
Contributor Author

vesellov commented Feb 10, 2021 •
edited
Loading

I must also mention that input parameter --activity-class-name is already there, but it seems there is a better way to pass it further in the flow. So I am also changing that here in that PR.

inclement
inclement reviewed Feb 10, 2021
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine with me - the reason this is not configurable is more that nobody has cared than that there's any reason not to allow it, if it's useful, and it doesn't seem to add too much extra to think about.

pythonforandroid/bootstraps/sdl2/build/templates/AndroidManifest.tmpl.xml Outdated Show resolved Hide resolved
pythonforandroid/bootstraps/common/build/build.py Outdated Show resolved Hide resolved
@vesellov vesellov changed the title added few input parameters to make possible to use custom java classes added few input parameters to make possible to use custom java classes and tweak AndroidManifest.xml Feb 10, 2021
@vesellov vesellov force-pushed the develop branch 6 times, most recently from fe7b460 to b9b22a7 Compare February 10, 2021 23:03
@vesellov vesellov requested a review from inclement February 12, 2021 15:07
inclement
inclement approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks, and sorry again for the delay approving.

@inclement inclement merged commit ab65c48 into kivy:develop Feb 14, 2021
@vesellov
Copy link
Contributor Author

Thanks for help @inclement ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclement inclement inclement approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vesellov @inclement