-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AndroidX #2385
Enable AndroidX #2385
Conversation
This reverts commit 899afae.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
It seems like it might be worth doing an explicit target api version check to help users avoid activating it accidentally, but I guess it doesn't really matter since older targets are generally not useful.
Given the multiple "trigger CI" commits it would have been nice if someone had squashed those before merging 😅 |
Enable the use of the AndroidX support library, as the current Android support library used by p4a is depreciated.
Implemented as described here https://developer.android.com/jetpack/androidx/migrate
No significant apk size change, until a
android.gradle_dependencies
is specified