Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AndroidX #2385

Merged
merged 13 commits into from
Mar 30, 2021
Merged

Enable AndroidX #2385

merged 13 commits into from
Mar 30, 2021

Conversation

RobertFlatt
Copy link
Contributor

Enable the use of the AndroidX support library, as the current Android support library used by p4a is depreciated.
Implemented as described here https://developer.android.com/jetpack/androidx/migrate
No significant apk size change, until a android.gradle_dependencies is specified

@Fak3 Fak3 mentioned this pull request Jan 24, 2021
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

It seems like it might be worth doing an explicit target api version check to help users avoid activating it accidentally, but I guess it doesn't really matter since older targets are generally not useful.

@inclement inclement merged commit 15dce3c into kivy:develop Mar 30, 2021
@obfusk
Copy link
Contributor

obfusk commented Mar 30, 2021

Given the multiple "trigger CI" commits it would have been nice if someone had squashed those before merging 😅

@RobertFlatt RobertFlatt deleted the enable_androidx branch March 30, 2021 23:19
@misl6 misl6 mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants