Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes App Icon and Presplash_Screen For Webview bootstrap #2556

Merged
merged 7 commits into from
Apr 6, 2022
Merged

Fixes App Icon and Presplash_Screen For Webview bootstrap #2556

merged 7 commits into from
Apr 6, 2022

Conversation

kengoon
Copy link
Contributor

@kengoon kengoon commented Mar 6, 2022

fix for #2552 and presplash_color not updating for webview bootstrap

@rtibbles rtibbles mentioned this pull request Mar 18, 2022
Closed
misl6
misl6 requested changes Mar 19, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase on develop and squash your commits into one?

@kengoon
Copy link
Contributor Author

kengoon commented Mar 20, 2022

done, that.

@misl6
Copy link
Member

misl6 commented Apr 6, 2022

I think that something gone wrong when you squashed into one commit.
No worries, I will squash it into one while merging.

For the next time: https://www.internalpointers.com/post/squash-commits-into-one-git

misl6
misl6 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will squash into one commit while merging.

@misl6 misl6 merged commit 85c4d1c into kivy:develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kengoon @misl6