Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps libffi to v3.4.2 + adds -fPIC on i686-linux-android #2578

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Bumps libffi to v3.4.2 + adds -fPIC on i686-linux-android #2578

merged 1 commit into from
Apr 16, 2022

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Apr 14, 2022 •
edited
Loading

  • Bumps libffi from v3.3 to v3.4.2 ( v3.3 was failing to build via Android-LLVM on macOS as -flto flag is present in CFLAGS by default (See: libffi/pull/590)
  • Added missing -fPIC to Archx86 (i686-linux-android)

⚠️ Do not merge it yet as it needs some tests during runtime.
✅ Tests passed during runtime on on_device_unit_tests (On a arm64-v8a device)

@misl6 misl6 requested a review from AndreMiras April 15, 2022 19:02
AndreMiras
AndreMiras approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@misl6 misl6 merged commit 0e87b99 into kivy:develop Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misl6 @AndreMiras