-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scipy/lapack CI tests #2617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great effort thank you 🙏
@misl6 feel free to merge if you're happy with it too
As said on Discord, looks absolutely fine to me to add a test regarding But, before merge, how about adding a testcase on on_device_unit_tests test app that does an actual (nothing so fancy) unittest when the test app is launched? ATM, when
|
I just added a scipy test to the test app, when I launch it on my android phone, it runs the test successfully, and exits (there is no kivy in app requirements, so app exits as soon as the test is done). It does not look like there is any crash/traceback.
@misl6 :can you please help understand what is the behaviour you expect to see? |
The test that you just added is probably already targeting our need, but we usually expect to have an app that shows the test results on the device where the testapp is running, so we can avoid inspecting the logs via adb (even if is a good idea to keep adb enabled while doing tests). When building with This is what we expect on Something similar is also shown when using |
1 similar comment
The test that you just added is probably already targeting our need, but we usually expect to have an app that shows the test results on the device where the testapp is running, so we can avoid inspecting the logs via adb (even if is a good idea to keep adb enabled while doing tests). When building with This is what we expect on Something similar is also shown when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This test was added in kivy#2617 but is now [failing our pull requests](https://github.com/kivy/python-for-android/pulls). * kivy#2617 @mzakharo, @misl6, @AndreMiras
Adding CI tests for downloading and extracting
LEGACY_NDK
, gfortran to build lapack/scipy. Follow-up PR to #2615