Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI compile aiohttp again. #2690

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Make CI compile aiohttp again. #2690

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b078955
Make CI compile aiohttp again.
xavierfiechter Oct 19, 2022
ebb9f4b
version variable and github url
xavierfiechter Oct 19, 2022
a360860
lost a newline
xavierfiechter Oct 19, 2022
6dee3ab
added missing line for pep
xavierfiechter Oct 19, 2022
cd0f04d
Changed URL
xavierfiechter Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pythonforandroid/recipes/aiohttp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
"""Build AIOHTTP"""
from typing import List
from pythonforandroid.recipe import CythonRecipe # type: ignore
from pythonforandroid.recipe import CppCompiledComponentsPythonRecipe


class AIOHTTPRecipe(CythonRecipe): # type: ignore # pylint: disable=R0903
"""Build AIOHTTP"""

version = "v3.6.2"
url = "https://github.com/aio-libs/aiohttp/archive/{version}.zip"
class AIOHTTPRecipe(CppCompiledComponentsPythonRecipe): # type: ignore # pylint: disable=R0903
version = "3.8.3"
url = "https://pypi.python.org/packages/source/a/aiohttp/aiohttp-{version}.tar.gz"
name = "aiohttp"

depends: List[str] = ["setuptools"]
call_hostpython_via_targetpython = False
install_in_hostpython = True

def get_recipe_env(self, arch):
env = super().get_recipe_env(arch)
env['LDFLAGS'] += ' -lc++_shared'
return env

Comment on lines +17 to 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flake8 is expecting an extra line here, CI is complaining:

pythonforandroid/recipes/aiohttp/__init__.py:19:1: E305 expected 2 blank lines after class or function definition, found 1


recipe = AIOHTTPRecipe()