Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply a patch from SDL upstream that fixes orientation settings #2730

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Apply a patch from SDL upstream that fixes orientation settings #2730

merged 1 commit into from
Jan 2, 2023

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jan 2, 2023

  • inverse landscapeLeft and landscapeRight (now behaves as described in SDL docs)
  • fix to match exactly Portrait (as it is contained in PortraitUpsideDown)

See: libsdl-org/SDL#6964 and #2724 (comment)

AndreMiras
AndreMiras approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@misl6 misl6 merged commit d3cb478 into kivy:develop Jan 2, 2023
@misl6 misl6 deleted the fix/android-orientation-sdl branch January 2, 2023 15:51
@misl6 misl6 mentioned this pull request Jan 21, 2023
Merged
shyamnathp pushed a commit to shyamnathp/python-for-android that referenced this pull request Feb 17, 2023
@misl6 @ShyamQt
Apply a patch from SDL upstream that fixes orientation settings (kivy…
ebb01bd 
…#2730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misl6 @AndreMiras