Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a recipe for mysql-connector-python #2974

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

This is a recipe for mysql-connector-python #2974

Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
146b0cd
This is a recipe for mysql-connector-python
kyprosantreou Feb 19, 2024
333a9dd
mysql-connector-python update
kyprosantreou Feb 19, 2024
0e506c0
mysql-connector-python fix
kyprosantreou Feb 21, 2024
d118c6f
Merge branch 'kivy:develop' into develop
kyprosantreou Feb 21, 2024
b42cd1e
fix the bug of 2 lines
kyprosantreou Feb 21, 2024
89f1869
error fixed
kyprosantreou Feb 24, 2024
ae6e077
Update pythonforandroid/recipes/mysql-connector-python/__init__.py
kyprosantreou Feb 26, 2024
9d6f182
update
kyprosantreou Feb 26, 2024
0823f81
update
kyprosantreou Mar 23, 2024
c561230
Merge branch 'kivy:develop' into develop
kyprosantreou Mar 23, 2024
64f3216
Update __init__.py
kyprosantreou Mar 26, 2024
8605308
update
kyprosantreou Apr 5, 2024
90227b3
Merge branch 'kivy:develop' into develop
kyprosantreou Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pythonforandroid/recipes/mysql-connector-python/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
from pythonforandroid.recipe import CompiledComponentsPythonRecipe


class MySQLConnectorPythonRecipe(CompiledComponentsPythonRecipe):

name = 'mysql-connector-python'
version = '8.3.0'
url = (
f'https://dev.mysql.com/get/Downloads/'
f'Connector-J/mysql-connector-j-{version}.tar.gz'
kyprosantreou marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

@AndreMiras AndreMiras Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops remove that line, we will get there I promise 😅
I've messed up the URL too, the prefix with "Connector-J" should be "Connector-Python" as well.
For example a full working URL would be, but we need to use the {version} template obviously
https://dev.mysql.com/get/Downloads/Connector-Python/mysql-connector-python-8.3.0-src.tar.gz

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂no problem we will fix it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not far from getting this merged, would you mind looking this up? We simply need to get that URL right.
Don't forget to check the linter locally before pushing too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can i test it locally?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the linting, running flake8 should be enough.

python -m venv venv
venv/bin/pip install flake8
venv/bin/flake8 pythonforandroid/

f'Connector-J/mysql-connector-python-{version}.tar.gz'
)
call_hostpython_via_targetpython = False

depends = ['python3', 'setuptools']


recipe = MySQLConnectorPythonRecipe()
Loading