make get_keyboard_height more dynamic #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayaurora
added a commit
that referenced
this pull request
Mar 27, 2015
make get_keyboard_height more dynamic
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using WIndow.softinput_mode='pan' with kivy. I noticed that changing the orientation of the screen (on android) (e.g. from portrait to landscape), caused the display to misbehave: eventhough the system keyboard had not be requested, the whole screen seem to be offset as if it had been.
The problem was that get_keyboard_height from the android module had a static notion of height. My patch causes it to reevaluate the height (this is especially important in case of dispaly orientation change).
With my app, I now get the expected behaviour.