Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flags to support SQLite full text search (FTS) at compilation #432

Closed
wants to merge 1 commit into from

Conversation

matphysrin
Copy link

In the SQLite (sqlite3) library, the full text search (FTS3) is not turned on at compilation. This commit turns it on by default. Please see Issue #431. I've tested these flags using OS X Yosemite 10.10.4 and Android 4.4.2.

@inclement
Copy link
Member

Sorry for the delay in replying about this. I'm not familiar with database technicalities, do you know if there's any significant downside likely to come with enabling this, like a larger binary size? Assuming not, I'll be happy to merge it.

@matphysrin
Copy link
Author

Sorry for the delay, this time on my side. I'm no expert either, but I tried myself compiling the library without and with FTS3 enabled and the resulting size of the binary is 774K and 912K, respectively. No idea whether you may consider this a significant size increase. FTS3 is enabled by default when using autoconf of sqlite. Consequently, most of the sqlite3 distributions around have it enabled. I can't imagine it could cause any significant drag on performance for non-full-text queries, as FTS3 is AFAIK a completely separate subsystem (virtual tables).

@AndreMiras
Copy link
Member

Thank you @matphysrin for improving p4a. I'm sorry your pull request didn't make it to the tree.
The good news is full text search FTS3 has been enabled since then in #672 and even updated to FTS4 in #936.

@AndreMiras AndreMiras closed this Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants