Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission groups #965

Closed
wants to merge 2 commits into from
Closed

Add permission groups #965

wants to merge 2 commits into from

Conversation

KeyWeeUsr
Copy link
Contributor

( extracted from https://android.googlesource.com/platform/frameworks/base/+/master/core/res/AndroidManifest.xml )

This might be later even included in documentation after autodoc works (again?).

closes #843

@inclement
Copy link
Member

Looks nice. Are there any licensing implications if these are extracted directly from the Android source?

@KeyWeeUsr
Copy link
Contributor Author

I'm not sure, at all, however it's also in Manifest.permission_group and also in casual Manifest documentation (docs is from source like Kivy does it with sphinx).

The documentation seems to be under CC Attribution 2.5 and the code I fetched it from is under Apache 2.0, however there's no code that is runnable, usable or actually related to the Android as a part of the project, this PR contains lists of names, so I'd treat it as plaintext / documentation, but with an attribution to the original license.

For example:

Permission names and permission groups are licensed under Apache 2.0 License,
Copyright 2006, The Android Open Source Project

@KeyWeeUsr
Copy link
Contributor Author

@inclement I'm not sure how to handle permissions similar to mocking permissions. It's in that state as I have it here even in the Manifest, which brings me to a thought that user is responsible for filtering the permissions and also it seems more reasonable for me to force users to choose only specific permissions only for their app and use groups for more comprehensive testing of their app.

On the other hand, a user can make an idiot from him/herself quite easily this way judging from that status, so it might be maybe more useful to have a group MOCK, which would have such permissions, or we could put it directly into DEVELOPMENT, but this collides with Manifest.

@KeyWeeUsr KeyWeeUsr closed this Jun 30, 2017
@KeyWeeUsr KeyWeeUsr deleted the perm_groups branch June 30, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: access to all permissions
2 participants