Add support for client certificates when connecting to upstream networks #80
+102
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably load the cert+key files into memory on config load so that it's not reading the file over and over. This will also prevent people from moving the files while the server is running which would then start causing errors. It feels kinda weird to have the cert+key int he Client constructor since they are entirely optional, how about a |
ItsOnlyBinary
force-pushed
the
client-cert
branch
2 times, most recently
from
f7a0382 to
8a4cb1d
Compare
ItsOnlyBinary
force-pushed
the
client-cert
branch
from
d029900 to
af54c11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #79