Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TR page bulk actions to JSON-RPC #1063

Closed
atodorov opened this issue Aug 11, 2019 · 1 comment
Closed

Refactor TR page bulk actions to JSON-RPC #1063

atodorov opened this issue Aug 11, 2019 · 1 comment
Labels
help wanted refactoring UI/UX
Milestone
patternfly-migration

Comments

@atodorov
Copy link
Member

atodorov commented Aug 11, 2019 •
edited
Loading

All of the blue menus post their data to backend view functions instead of making use of existing JSON-RPC. That is except the right-most Links menu, which is new.

Also all of these actions seem to have separate backend handlers in the cases when they are performing bulk update vs. the case when they are performing a single update (triggered via other widgets in the UI).

This needs to be cleaned up significantly and will help with converting this page to Patternfly.

tr_blue_menus
@atodorov
Copy link
Member Author

atodorov commented Jan 8, 2020

The methods which are currerntly not converted to JSON-RPC are:

  • changeCaseRunAssignee
  • updateRunStatus
  • and the js-update-case button, which updates the text to the latest version !

@atodorov atodorov added this to the patternfly-migration milestone Jan 17, 2020
rsasov added a commit to rsasov/Kiwi that referenced this issue Apr 23, 2020
@rsasov
Refactor updateAssignee to use JSON-RPC. Refs kiwitcms#1063
a6cf6f0 
Remove unused imports

Refactor update of assignee rpc call

Remove override of assignee form field

Remove trimming

Fix tests for changeAssignee

Revert change in test case for updateAssignee with invalid id

Add tests for updateAssignee
rsasov added a commit to rsasov/Kiwi that referenced this issue Apr 23, 2020
@rsasov
Refactor updateAssignee to use JSON-RPC. Refs kiwitcms#1063
15fc82d 
Remove unused imports

Refactor update of assignee rpc call

Remove override of assignee form field

Remove trimming

Fix tests for changeAssignee

Revert change in test case for updateAssignee with invalid id

Add tests for updateAssignee
rsasov added a commit to rsasov/Kiwi that referenced this issue Apr 23, 2020
@rsasov
Refactor updateAssignee to use JSON-RPC. Refs kiwitcms#1063
0f9b4e9 
Remove unused imports

Refactor update of assignee rpc call

Remove override of assignee form field

Remove trimming

Fix tests for changeAssignee

Revert change in test case for updateAssignee with invalid id

Add tests for updateAssignee

Making the lint happy
rsasov added a commit to rsasov/Kiwi that referenced this issue Apr 28, 2020
@rsasov
Refactor updateAssignee to use JSON-RPC. Refs kiwitcms#1063
ed16c9a 
Remove unused imports

Refactor update of assignee rpc call

Remove override of assignee form field

Remove trimming

Fix tests for changeAssignee

Revert change in test case for updateAssignee with invalid id

Add tests for updateAssignee

Making the lint happy

Fix cosmetic remarks and update tests
atodorov pushed a commit that referenced this issue Apr 28, 2020
@rsasov
Refactor updateAssignee to use JSON-RPC. Refs #1063
8c9f6e7
rsasov added a commit to rsasov/Kiwi that referenced this issue Apr 28, 2020
@rsasov
Refactor update case text version to use jsonRpc. Fixes kiwitcms#1063
3b8e038 
Fix remarks
rsasov added a commit to rsasov/Kiwi that referenced this issue May 6, 2020
@rsasov
Refactor update case text version to use jsonRpc. Fixes kiwitcms#1063
75dd806 
Fix remarks

Change latest flag to integer -1 value. Revert form field of case text version to integer.
rsasov added a commit to rsasov/Kiwi that referenced this issue May 6, 2020
@rsasov
Refactor update case text version to use jsonRpc. Fixes kiwitcms#1063
4ad0b83 
Fix remarks

Change latest flag to integer -1 value. Revert form field of case text version to integer.

Extract case text version from form in variable
rsasov added a commit to rsasov/Kiwi that referenced this issue May 7, 2020
@rsasov
Refactor update case text version to use jsonRpc. Fixes kiwitcms#1063
09a4d75 
Fix remarks

Change latest flag to integer -1 value. Revert form field of case text version to integer.

Extract case text version from form in variable

Revert todo for missing permissions that got accidentaly removed
rsasov added a commit to rsasov/Kiwi that referenced this issue May 11, 2020
@rsasov
Refactor update case text version to use jsonRpc. Fixes kiwitcms#1063
dea9568 
Fix remarks

Change latest flag to integer -1 value. Revert form field of case text version to integer.

Extract case text version from form in variable

Revert todo for missing permissions that got accidentaly removed

Refactor selectors for update text version. Refactor text version field for UpdateExecutionForm
rsasov added a commit to rsasov/Kiwi that referenced this issue May 11, 2020
@rsasov
Refactor update case text version to use jsonRpc. Fixes kiwitcms#1063
a9bc88f 
Fix remarks

Change latest flag to integer -1 value. Revert form field of case text version to integer.

Extract case text version from form in variable

Revert todo for missing permissions that got accidentaly removed

Refactor selectors for update text version. Refactor text version field for UpdateExecutionForm

Revert still valid tests, update assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted refactoring UI/UX
Projects
None yet
Milestone
patternfly-migration
Development

No branches or pull requests
1 participant
@atodorov