Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML-RPC: unify RPC namespace with model names #153

Closed
atodorov opened this issue Dec 17, 2017 · 1 comment
Closed

XML-RPC: unify RPC namespace with model names #153

atodorov opened this issue Dec 17, 2017 · 1 comment

Comments

@atodorov
Copy link
Member

For example there's the model TestBuild but the RPC namespace & client-side class is called Build. These, together with the logging prefix need to be unified/simplified to make naming consistent and avoid confusion for users.

atodorov added a commit that referenced this issue Jan 26, 2018
instead use TestRun.filter and TestCaseRun.filter RPC methods
atodorov added a commit that referenced this issue Jan 26, 2018
introduce a more generic RPC method called Build.filter() which
is a proxy for the underlying QuerySet. Refs #153

Update the client-side API library to match accordingly.
atodorov added a commit that referenced this issue Jan 26, 2018
	Env.filter_groups -> Env.Group.filter
	Env.filter_properties -> Env.Property.filter
	Env.filter_values -> Env.Value.filter
atodorov added a commit that referenced this issue Jan 26, 2018
replace these methods with Product.filter() method
atodorov added a commit that referenced this issue Jan 26, 2018
refs #153.

	Product.check_category -> Category.filter
	Product.filter_categories -> Category.filter
	Product.get_categories -> Category.filter
	Product.get_category -> Category.filter
atodorov added a commit that referenced this issue Jan 29, 2018
	Env.filter_groups -> Env.Group.filter
	Env.filter_properties -> Env.Property.filter
	Env.filter_values -> Env.Value.filter
atodorov added a commit that referenced this issue Jan 29, 2018
replace these methods with Product.filter() method
atodorov added a commit that referenced this issue Jan 29, 2018
refs #153.

	Product.check_category -> Category.filter
	Product.filter_categories -> Category.filter
	Product.get_categories -> Category.filter
	Product.get_category -> Category.filter
atodorov added a commit that referenced this issue Feb 2, 2018
instead use TestRun.filter and TestCaseRun.filter RPC methods
atodorov added a commit that referenced this issue Feb 2, 2018
introduce a more generic RPC method called Build.filter() which
is a proxy for the underlying QuerySet. Refs #153

Update the client-side API library to match accordingly.
atodorov added a commit that referenced this issue Feb 2, 2018
	Env.filter_groups -> Env.Group.filter
	Env.filter_properties -> Env.Property.filter
	Env.filter_values -> Env.Value.filter
atodorov added a commit that referenced this issue Feb 2, 2018
replace these methods with Product.filter() method
atodorov added a commit that referenced this issue Feb 2, 2018
refs #153.

	Product.check_category -> Category.filter
	Product.filter_categories -> Category.filter
	Product.get_categories -> Category.filter
	Product.get_category -> Category.filter
@atodorov
Copy link
Member Author

atodorov commented Feb 8, 2018

closed via #207

@atodorov atodorov closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant