Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests for missing coverage in tcms.rpc.api.testcasestatus #1624

Closed
kiwitcms-bot opened this issue Apr 30, 2020 · 4 comments
Closed
Assignees
Labels
MLH Fellowship https://fellowship.mlh.io/programs/open-source € 20 bounty See bounty-program milestone

Comments

@kiwitcms-bot
Copy link
Member

kiwitcms-bot commented Apr 30, 2020

Kiwi TCMS needs additional automated test(s) as mentioned in subject.

Definition of Done:

  • full coverage for the module or class mentioned in the title. This means both positive/negative scenarios where this makes sense or scenarios which traverse different branches of the code where that makes sense.
  • test class/test method names are descriptive and reflect the behavior of the subject under test. A good scheme to follow is Test<ClassUnderTest>.test_[who][what][expected_results]
  • CI pass
  • All code review passed & PR merged

Hints:

This issue is part of Kiwi TCMS open source bounty program. For more information see the link(s) in bounty-program milestone

@kiwitcms-bot kiwitcms-bot added the € 20 bounty See bounty-program milestone label Apr 30, 2020
@kiwitcms-bot kiwitcms-bot added this to the bounty-program milestone Apr 30, 2020
@iamabhishek0
Copy link
Contributor

If no one is working on this issue, I would like to take this up.

@atodorov atodorov added the MLH Fellowship https://fellowship.mlh.io/programs/open-source label Oct 24, 2020
@atodorov
Copy link
Member

IMPORTANT: This issue/bounty has been assigned to an MLH fellow who is currently working on it, see here. Pull requests towards the same issue from other contributors will not be considered at this time. Please pick something else to work on!

@iamabhishek0
Copy link
Contributor

@atodorov while trying to write automated tests for tcms.rpc.api.testcasestatus I noticed that there is no Factory Class for TestCaseStatus in tcms/tests/factories.py. Do you recommend adding one?

@atodorov
Copy link
Member

@atodorov while trying to write automated tests for tcms.rpc.api.testcasestatus I noticed that there is no Factory Class for TestCaseStatus in tcms/tests/factories.py. Do you recommend adding one?

Do you need one? There are several statuses pre-existing and you can always create more directly - same thing when working with models outside of tests.

iamabhishek0 added a commit to MLH-Fellowship/Kiwi that referenced this issue Oct 30, 2020
iamabhishek0 added a commit to MLH-Fellowship/Kiwi that referenced this issue Oct 30, 2020
iamabhishek0 added a commit to MLH-Fellowship/Kiwi that referenced this issue Oct 30, 2020
asankov pushed a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MLH Fellowship https://fellowship.mlh.io/programs/open-source € 20 bounty See bounty-program milestone
Projects
None yet
Development

No branches or pull requests

3 participants