Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] add/remove bug to use common implementation #18

Closed
atodorov opened this issue May 26, 2017 · 0 comments
Closed

[refactor] add/remove bug to use common implementation #18

atodorov opened this issue May 26, 2017 · 0 comments
Labels
refactoring

Comments

@atodorov
Copy link
Member

atodorov commented May 26, 2017 •
edited
Loading

While working on upstream #79 I have discovered that for adding and removing bugs we use separate code paths which are very similar. This applies both to the Python code and to the JavaScript code. These can be refactored to use a single implementation.

  • Test Case Run add/remove bug uses testruns.views.bug() and its internal class CaseRunBugActions and from tesrun_actions.js -> addCaseRunBug(), removeCaseRunBug(), updateBugsActionAdd() and updateBugsActionRemvoe()
atodorov added a commit that referenced this issue Dec 18, 2018
@atodorov
Refactor TestCase -> Bugs tab -> Remove to JSON-RPC. Refs #18
073a043
atodorov added a commit that referenced this issue Dec 19, 2018
@atodorov
Refactor TestCase -> Bugs tab -> Remove to JSON-RPC. Refs #18
a0cc054
atodorov added a commit that referenced this issue Dec 22, 2018
@atodorov
Refactor removeCaseRunBug() to JSON-RPC, Refs #18
93ea19a 
the UI updates are a bit tricky b/c we still show bugs that have
been reported in other TestRuns or generally attached to the
TestCase. The idea is that these can be known issues and should be
easy to find when testing (i.e. we're seeing this behavior for the
first time but somebody else had reported it already).
atodorov added a commit that referenced this issue Dec 22, 2018
@atodorov
Refactor removeCaseRunBug() to JSON-RPC, Refs #18
00bc787 
the UI updates are a bit tricky b/c we still show bugs that have
been reported in other TestRuns or generally attached to the
TestCase. The idea is that these can be known issues and should be
easy to find when testing (i.e. we're seeing this behavior for the
first time but somebody else had reported it already).
@atodorov atodorov changed the title [refactor] add/remove bug to use common implementation #184 [refactor] add/remove bug to use common implementation Jan 13, 2019
atodorov added a commit that referenced this issue Jan 13, 2019
@atodorov
Implement Bugs card for Test Case page. Refs #18
a89cdc3 
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!
atodorov added a commit that referenced this issue Jan 13, 2019
@atodorov
Implement Bugs card for Test Case page. Refs #18
c44970e 
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!
atodorov added a commit that referenced this issue Jan 13, 2019
@atodorov
Implement Bugs card for Test Case page. Refs #18
f20e246 
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!
atodorov added a commit that referenced this issue Jan 15, 2019
@atodorov
Implement Bugs card for Test Case page. Refs #18
9ea370c 
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!
atodorov added a commit that referenced this issue Jan 15, 2019
@atodorov
Remove old templates and unused code around them
22c10b9 
- remove all legacy templates around the TestCase view page
- remove now unused JavaScript, lots of functions around
  tabs and expanding content
- remove backend views which were only used via AJAX calls
  from the removed templates, Refs #18
- remove/update tests, in particular the new view renders
  only TestPlans which have a Test Run executed, including the
  current TestCase. Other TestPlans which contain the current
  TestCase (but may not yet have test runs) are loaded via RPC
  for which we can't test right now.
atodorov added a commit that referenced this issue Jan 16, 2019
@atodorov
Implement Bugs card for Test Case page. Refs #18
1ccba3e 
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!
atodorov added a commit that referenced this issue Jan 16, 2019
@atodorov
Remove old templates and unused code around them
9ae0e77 
- remove all legacy templates around the TestCase view page
- remove now unused JavaScript, lots of functions around
  tabs and expanding content
- remove backend views which were only used via AJAX calls
  from the removed templates, Refs #18
- remove/update tests, in particular the new view renders
  only TestPlans which have a Test Run executed, including the
  current TestCase. Other TestPlans which contain the current
  TestCase (but may not yet have test runs) are loaded via RPC
  for which we can't test right now.
atodorov added a commit that referenced this issue Feb 8, 2019
@atodorov
[api] New method Bug.report, Refs #18
b90c4bf 
- returns pre-configured URL for easier bug reporting
- refactor the UI to use this new RPC method
atodorov added a commit that referenced this issue Feb 8, 2019
@atodorov
[api] Bug.create() now accepts new parameter auto_report=False
552d918 
- when auto_report=True will automatically try to comment on the
issue using IssueTracker integrations.

- front-end now uses this new RPC instead of legacy AJAX view.
  Fixes #18
atodorov added a commit that referenced this issue Feb 9, 2019
@atodorov
[api] New method Bug.report, Refs #18
f6ff0cf 
- returns pre-configured URL for easier bug reporting
- refactor the UI to use this new RPC method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atodorov