Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examine and refactor get_text_with_version and friends #198

Closed
atodorov opened this issue Feb 1, 2018 · 1 comment
Closed

Examine and refactor get_text_with_version and friends #198

atodorov opened this issue Feb 1, 2018 · 1 comment

Comments

@atodorov
Copy link
Member

atodorov commented Feb 1, 2018

There are methods called get_text_with_version which are used in only couple of places. Along them are other methods named text_exist, text_checksum, latest_text_version which all need to be examined and updated/deleted where appropriate.
@atodorov
Copy link
Member Author

From these only get_text_with_version and latest_text_version are left standing.

atodorov added a commit that referenced this issue Jun 26, 2018
@atodorov
Remove unused text_exist() methods. Refs #198
77077dd
atodorov added a commit that referenced this issue Jun 26, 2018
@atodorov
Remove unnecessary TestPlan.text_checksum(). Refs #198
5ebcbe7
atodorov added a commit that referenced this issue Jun 27, 2018
@atodorov
Remove unused text_exist() methods. Refs #198
2dca436
atodorov added a commit that referenced this issue Jun 27, 2018
@atodorov
Remove unnecessary TestPlan.text_checksum(). Refs #198
2e551f5
atodorov added a commit that referenced this issue Jul 9, 2018
@atodorov
Remove TestPlanText model, use TestPlan.text instead
f9fd339 
Now that we have proper history tracking we don't need a separate
model to hold versions of the text. Instead this can be a field
inside TestPlan model.

- remove unused showMoreSummary() and showShortSummary()
  JavaScript functions
- remove now unnecessary clone_form.copy_texts ption
- simplify plan/get_docs.html template and merge with plan/get.html
- remove TestPlan.latest_text() and TestPlan.add_text() methods,
  refs #198
atodorov added a commit that referenced this issue Jul 9, 2018
@atodorov
Remove TestPlanText model, use TestPlan.text instead
7f0a5bd 
Now that we have proper history tracking we don't need a separate
model to hold versions of the text. Instead this can be a field
inside TestPlan model.

- remove unused showMoreSummary() and showShortSummary()
  JavaScript functions
- remove now unnecessary clone_form.copy_texts ption
- simplify plan/get_docs.html template and merge with plan/get.html
- remove TestPlan.latest_text() and TestPlan.add_text() methods,
  refs #198
atodorov added a commit that referenced this issue Jul 9, 2018
@atodorov
Remove TestPlanText model, use TestPlan.text instead
7898770 
Now that we have proper history tracking we don't need a separate
model to hold versions of the text. Instead this can be a field
inside TestPlan model.

- remove unused showMoreSummary() and showShortSummary()
  JavaScript functions
- remove now unnecessary clone_form.copy_texts ption
- simplify plan/get_docs.html template and merge with plan/get.html
- remove TestPlan.latest_text() and TestPlan.add_text() methods,
  refs #198
atodorov added a commit that referenced this issue Jul 9, 2018
@atodorov
Remove TestPlanText model, use TestPlan.text instead
d2f81ab 
Now that we have proper history tracking we don't need a separate
model to hold versions of the text. Instead this can be a field
inside TestPlan model.

- remove unused showMoreSummary() and showShortSummary()
  JavaScript functions
- remove now unnecessary clone_form.copy_texts ption
- simplify plan/get_docs.html template and merge with plan/get.html
- remove TestPlan.latest_text() and TestPlan.add_text() methods,
  refs #198
atodorov added a commit that referenced this issue Jul 10, 2018
@atodorov
Remove TestPlanText model, use TestPlan.text instead
7d331dc 
Now that we have proper history tracking we don't need a separate
model to hold versions of the text. Instead this can be a field
inside TestPlan model.

- remove unused showMoreSummary() and showShortSummary()
  JavaScript functions
- remove now unnecessary clone_form.copy_texts ption
- simplify plan/get_docs.html template and merge with plan/get.html
- remove TestPlan.latest_text() and TestPlan.add_text() methods,
  refs #198
atodorov added a commit that referenced this issue Jan 20, 2019
@atodorov
[db] Remove TestCaseText model, merge into TestCase.text field
5750b34 
- TestCaseText model is removed and provided as TestCase.text field
- TestCase.latest_text() is removed in favor of TestCase.text
- TestCase.latest_text_version() is removed in favor of
  TestCase.history.latest().history_id
- TestCase.get_text_with_version() will read from the history
- TestCase.add_text() is removed
- TestCase.get_text_versions() - removed
- TestCaseRun.latest_text() is removed
- TestCaseRun.get_text_with_version() is removed in favor of
  TestCase.get_text_with_version()
- NoneText is removed
- tcms.core.utils.checksum is removed
- tcms.utils.dict_utils is removed
- update existing templates and forms
- update test suite to generate historical records

Closes #198
atodorov added a commit that referenced this issue Jan 20, 2019
@atodorov
[db] Remove TestCaseText model, merge into TestCase.text field
c87e751 
- TestCaseText model is removed and provided as TestCase.text field
- TestCase.latest_text() is removed in favor of TestCase.text
- TestCase.latest_text_version() is removed in favor of
  TestCase.history.latest().history_id
- TestCase.get_text_with_version() will read from the history
- TestCase.add_text() is removed
- TestCase.get_text_versions() - removed
- TestCaseRun.latest_text() is removed
- TestCaseRun.get_text_with_version() is removed in favor of
  TestCase.get_text_with_version()
- NoneText is removed
- tcms.core.utils.checksum is removed
- tcms.utils.dict_utils is removed
- update existing templates and forms
- update test suite to generate historical records

Closes #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atodorov