Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use get_full_url on the webpages #518

Closed
okainov opened this issue Sep 6, 2018 · 3 comments
Closed

Don't use get_full_url on the webpages #518

okainov opened this issue Sep 6, 2018 · 3 comments

Comments

@okainov
Copy link
Contributor

okainov commented Sep 6, 2018

Please don't use get_full_url on the pages. Use only normal urls.

When I copy the production website to my local machine, half of the links become broken (pointing to production instead of current)

The only point where you really need full one is emails.

@atodorov
Copy link
Member

atodorov commented Sep 6, 2018

Version and pages on which you see this ?

@okainov
Copy link
Contributor Author

okainov commented Sep 6, 2018

Our Kiwi baseline is from 531bc99

Main dashboard page (test plan links), links on testplan view "tree view" page.

@atodorov
Copy link
Member

atodorov commented Sep 6, 2018

All of these have been updated recently, that was issue #380. Try the latest version and then reopen 380 if you see this happening elsewhere.

NOTE: there seems to be a bug with creating slugs (short URLs) for non ascii characters and that may cause the dashboard rendering to crash. I just saw such an issue with Chinese titles in Test Plan. Working on a fix.

@atodorov atodorov closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants