Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: consider removing get_full_url() #380

Closed
atodorov opened this issue Jun 22, 2018 · 3 comments
Closed

RFE: consider removing get_full_url() #380

atodorov opened this issue Jun 22, 2018 · 3 comments

Comments

@atodorov
Copy link
Member

This method relies on the actual ip/fqdn being properly configured to produce a full URL to the given object. This often leads to issues.

Items to consider:

  1. Remove the hostname part of the URL and use relative URLs starting at /.

ATM I don't know why initially we've considered linking via the full URL.

  1. Use a different method of linking between objects: this will likely require lots of updates to templates.
@atodorov
Copy link
Member Author

Note: for integration with external services like email/bugtracker reports we still need the full URLs.

@atodorov
Copy link
Member Author

Related to #450 - if we didn't use get_full_url everywhere this problem would have been less visible.

@atodorov atodorov mentioned this issue Aug 1, 2018
Closed
@atodorov
Copy link
Member Author

#478 is also manifestation of this issue

atodorov added a commit that referenced this issue Aug 17, 2018
@atodorov
Don't use get_full_url where not needed. Refs #380
810e7b4
atodorov added a commit that referenced this issue Aug 19, 2018
@atodorov
Don't use get_full_url where not needed. Closes #380
eda96d1
@atodorov atodorov mentioned this issue Sep 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atodorov