-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all RPC related classes from XMLRPC* to RPC #682
Labels
Comments
I found the following occurrences. Is it ok if I rename them.
|
Note: renaming |
AleksMat
added a commit
to AleksMat/Kiwi
that referenced
this issue
Oct 5, 2019
AleksMat
added a commit
to AleksMat/Kiwi
that referenced
this issue
Oct 5, 2019
Merged
atodorov
pushed a commit
to AleksMat/Kiwi
that referenced
this issue
Oct 8, 2019
atodorov
pushed a commit
to AleksMat/Kiwi
that referenced
this issue
Oct 8, 2019
atodorov
pushed a commit
that referenced
this issue
Oct 8, 2019
atodorov
pushed a commit
that referenced
this issue
Oct 8, 2019
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 23, 2019
- `XMLRPCUpdateCaseForm` -> `UpdateForm` - `XMLRPCNewRunForm` -> `NewForm` - `XMLRPCUpdateRunForm` -> `UpdateForm` - `XMLRPCNewExecutionForm` -> `NewExecutionForm` - `XMLRPCUpdateExecutionForm` -> `UpdateExecutionForm`
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 23, 2019
- `XMLRPCUpdateCaseForm` -> `UpdateForm` - `XMLRPCNewRunForm` -> `NewForm` - `XMLRPCUpdateRunForm` -> `UpdateForm` - `XMLRPCNewExecutionForm` -> `NewExecutionForm` - `XMLRPCUpdateExecutionForm` -> `UpdateExecutionForm`
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 23, 2019
- `XMLRPCCheckboxInput` -> `CheckboxInput` - `XMLRPCSerializer` -> `Serializer`
this is the grep outline after #1218 is merged
|
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 24, 2019
- `XMLRPCUpdateCaseForm` -> `UpdateForm` - `XMLRPCNewRunForm` -> `NewForm` - `XMLRPCUpdateRunForm` -> `UpdateForm` - `XMLRPCNewExecutionForm` -> `NewExecutionForm` - `XMLRPCUpdateExecutionForm` -> `UpdateExecutionForm`
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 24, 2019
- `XMLRPCCheckboxInput` -> `CheckboxInput` - `XMLRPCSerializer` -> `Serializer`
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 24, 2019
- `XMLRPCUpdateCaseForm` -> `UpdateForm` - `XMLRPCNewRunForm` -> `NewForm` - `XMLRPCUpdateRunForm` -> `UpdateForm` - `XMLRPCNewExecutionForm` -> `NewExecutionForm` - `XMLRPCUpdateExecutionForm` -> `UpdateExecutionForm`
asankov
added a commit
to asankov/Kiwi
that referenced
this issue
Nov 24, 2019
- `XMLRPCCheckboxInput` -> `CheckboxInput` - `XMLRPCSerializer` -> `Serializer`
atodorov
pushed a commit
that referenced
this issue
Nov 24, 2019
- `XMLRPCUpdateCaseForm` -> `UpdateForm` - `XMLRPCNewRunForm` -> `NewForm` - `XMLRPCUpdateRunForm` -> `UpdateForm` - `XMLRPCNewExecutionForm` -> `NewExecutionForm` - `XMLRPCUpdateExecutionForm` -> `UpdateExecutionForm`
atodorov
pushed a commit
that referenced
this issue
Nov 24, 2019
- `XMLRPCCheckboxInput` -> `CheckboxInput` - `XMLRPCSerializer` -> `Serializer`
rsasov
added a commit
to rsasov/Kiwi
that referenced
this issue
Jan 19, 2020
rsasov
added a commit
to rsasov/Kiwi
that referenced
this issue
Jan 21, 2020
Fix remarks Fix remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, a lot of our classes are prefixed with
XMLRPC*
. However, we support both XML-RPC and JSON-RPC. Both APIS use the same logic, so all of these classes names are misleading.A good approach would be to implement a
pylint
plugin for this to enforce the convention and drive the changeThe text was updated successfully, but these errors were encountered: