Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new linter: Do not use OneToOneField #735

Closed
atodorov opened this issue Jan 23, 2019 · 0 comments
Closed

new linter: Do not use OneToOneField #735

atodorov opened this issue Jan 23, 2019 · 0 comments
Labels
help wanted

Comments

@atodorov
Copy link
Member

We need a checker for kiwi_lint to warn about usage of OneToOneField. There aren't many such fields left but they don't play well with our history framework b/c we haven't enabled history on these relations.

The decision is to migrate OneToOneField relations back into the main model so a pylint checker is needed to discover them.
@jorgii jorgii mentioned this issue May 21, 2019
Closed
jorgii added a commit to jorgii/Kiwi that referenced this issue May 28, 2019
@jorgii
Use R4531 code for one-to-one-field-checker.
8a1c1cc 
Fixes kiwitcms#735
jorgii added a commit to jorgii/Kiwi that referenced this issue May 28, 2019
@jorgii
Use R4531 code for one-to-one-field-checker.
f4b2b00 
Fixes kiwitcms#735
atodorov pushed a commit that referenced this issue Jun 6, 2019
@jorgii @atodorov
Use R4531 code for one-to-one-field-checker.
7ec5763 
Fixes #735
atodorov pushed a commit that referenced this issue Jun 6, 2019
@jorgii @atodorov
Add OneToOneFieldChecker. Fixes #735
092c0d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atodorov