Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkreference permissions not set by default for the Tester group #881

Closed
atodorov opened this issue Mar 27, 2019 · 0 comments
Closed

linkreference permissions not set by default for the Tester group #881

atodorov opened this issue Mar 27, 2019 · 0 comments
Labels
security Pull requests that address a security vulnerability
Milestone
bug-tracker integ...

Comments

@atodorov
Copy link
Member

atodorov commented Mar 27, 2019 •
edited
Loading

These permissions are not applied to the Tester group but more importantly they are not checked inside of the application. I am able to pass link references to TestExecution records as much as I like.
@atodorov atodorov added the security Pull requests that address a security vulnerability label Mar 27, 2019
@atodorov atodorov added this to the bug-tracker integration milestone Jul 30, 2019
atodorov added a commit that referenced this issue Aug 11, 2019
@atodorov
Use TestExecution.add_link() and TestExecution.remove_link() in UI
2864417 
- API TestExecution.add_link() now returns serialized LinkReference
- API TestExecution.remove_link() now accepts dict params
- update tests to match new behavior

- remove unused linkreference views, forms and tests modules
- update JavaScript to match usage of the new API
- Refs #881 wrt missing LinkReference permissions
atodorov added a commit that referenced this issue Aug 11, 2019
@atodorov
Use TestExecution.add_link() and TestExecution.remove_link() in UI
685ba13 
- API TestExecution.add_link() now returns serialized LinkReference
- API TestExecution.remove_link() now accepts dict params
- update tests to match new behavior

- remove unused linkreference views, forms and tests modules
- update JavaScript to match usage of the new API
- Refs #881 wrt missing LinkReference permissions
atodorov added a commit that referenced this issue Aug 11, 2019
@atodorov
Use TestExecution.add_link() and TestExecution.remove_link() in UI
5fa33aa 
- API TestExecution.add_link() now returns serialized LinkReference
- API TestExecution.remove_link() now accepts dict params
- update tests to match new behavior

- remove unused linkreference views, forms and tests modules
- update JavaScript to match usage of the new API
- Refs #881 wrt missing LinkReference permissions
atodorov added a commit that referenced this issue Aug 12, 2019
@atodorov
Use TestExecution.add_link() and TestExecution.remove_link() in UI
05f9f88 
- API TestExecution.add_link() now returns serialized LinkReference
- API TestExecution.remove_link() now accepts dict params
- update tests to match new behavior

- remove unused linkreference views, forms and tests modules
- update JavaScript to match usage of the new API
- Refs #881 wrt missing LinkReference permissions
atodorov added a commit that referenced this issue Aug 12, 2019
@atodorov
[db] Apply linkreference permissions to Tester group. Fixes #881
d841191 
NOTE: administrators of existing applications will need to
apply these permissions by hand via the Admin section of the
application.
atodorov added a commit that referenced this issue Aug 12, 2019
@atodorov
[db] Apply linkreference permissions to Tester group. Fixes #881
8235d97 
NOTE: administrators of existing applications will need to
apply these permissions by hand via the Admin section of the
application.
@atodorov atodorov mentioned this issue Sep 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Milestone
bug-tracker integration
Development

No branches or pull requests
1 participant
@atodorov