Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the component field to a searchable field #882

Closed
mikii111 opened this issue Mar 28, 2019 · 5 comments
Closed

Make the component field to a searchable field #882

mikii111 opened this issue Mar 28, 2019 · 5 comments

Comments

@mikii111
Copy link

At the moment you need to know all the components name and you need to know the exakt name

Would be great if you could have a list with all the components and select the one you need and that the field was searchable

e.g.
We have a component named 'dynamic attributes' and one called 'attributes'
I would like to be able to add 'dynamic attributes' without knowing the full name, so if I enter attribute I can select the right one.

@atodorov
Copy link
Member

atodorov commented Jan 8, 2020

@mikii111 - on which page is that ? If the issue is still relevant please add more details how to reproduce and screenshots.

@Prome88
Copy link
Contributor

Prome88 commented Jan 9, 2020

I'm guessing that he is referring to test case view Components -https://public.tenant.kiwitcms.org/case/5754/ .

image

Product has 3 components:

  • Test component 1
  • Test component 2
  • Test component 3

Search is a bit clunky:

  • Searching for test gives 0 results
  • Searching for Test gives just 2 results
  • Searching for compon gives 0 results

I'm assuming that search is case sensitive and only searches from the start.

Drop-down with all available values combined with improved search (non case-sensitive, search over whole string) would be more user friendly.

@atodorov
Copy link
Member

atodorov commented Jan 9, 2020

@Prome88 thanks.

"Test component 2" is assigned to a different product, that's why it doesn't come up.

The rest should be easy to do. Just need to instruct the FE layer how to query the DB(, e.g. use name_icontains or similar).

@Prome88
Copy link
Contributor

Prome88 commented Jan 9, 2020

I've assigned it to proper Product, but it still only shows 2 results (now Test component 3 is missing)
image

@atodorov
Copy link
Member

atodorov commented Jan 9, 2020

I've assigned it to proper Product, but it still only shows 2 results (now Test component 3 is missing)

I can see that the JSON RPC request returns all 3 of them. Maybe the popup widget just displays 2. Appears to be the same behavior wherever the same widget is used. For tags it also shows only 2 entries. For example there are several tags starting with "Adroid " but you need to type the entirety of it (incl. space) to see some of them, otherwise they just don't appear.

atodorov added a commit that referenced this issue Oct 11, 2020
- use display() definition to simplify the code
- use limit definition to show more results and workaround issues
  like #882
atodorov added a commit that referenced this issue Oct 11, 2020
- filters using icontains instead of startswith
- uses limit to show more results
- uses display() to simplify the code
atodorov added a commit that referenced this issue Oct 11, 2020
- use display() definition to simplify the code
- use limit definition to show more results and workaround issues like
  #882
- filters using icontains instead of startswith
atodorov added a commit that referenced this issue Oct 11, 2020
- use display() definition to simplify the code
- use limit definition to show more results and workaround issues
  like #882
atodorov added a commit that referenced this issue Oct 11, 2020
- use display() definition to simplify the code
- use limit definition to show more results and workaround issues like
  #882
- filters using icontains instead of startswith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants