Improvements around comments #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4895
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
+ Coverage 73.83% 73.88% +0.05%
==========================================
Files 121 121
Lines 4788 4798 +10
Branches 596 595 -1
==========================================
+ Hits 3535 3545 +10
+ Misses 1048 1046 -2
- Partials 205 207 +2
Continue to review full report at Codecov.
|
atodorov
force-pushed
the
next_release
branch
from
dbd8435 to
ab681a5
Compare
atodorov
changed the title
- this field is not used when removing comments. Only comment_id is actually used! - get_details_case_run.html was displaying the wrong value for object_pk: it was showing TC.pk instead of TE.pk
instead of flagging comments as removed delete them from DB
we do this with a pre-delete signal b/c the object_pk field isn't a FK relationship but rather an integer field so we can't rely on a cascading delete!
previously this method didn't check for the necessary permissions
allows to remove 1 or all comments associated with TestExecution
replaces a view which we don't really need and want to delete so we can unblock #959
original solution proposed by @ohporter
atodorov
force-pushed
the
next_release
branch
from
ab681a5 to
a1e2894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.