Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for API method tcms.bugs.api.add_tag(). Refs #1597 #1689

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Add tests for API method tcms.bugs.api.add_tag(). Refs #1597 #1689

merged 1 commit into from
Jul 9, 2020

Conversation

mfonism
Copy link
Contributor

@mfonism mfonism commented May 24, 2020 •
edited
Loading

This PR adds tests for the add_tag() api method in tcms/bugs/api.py as per #1597

@mfonism mfonism force-pushed the 2020.05.24/issue/1597/test-add-tag branch from 0932738 to 840acbf Compare May 24, 2020 21:31
@mfonism mfonism changed the title Add tests for API method in tcms/bugs/api.py Add tests for API method tcms.bugs.api.add_tag() May 25, 2020
atodorov
atodorov requested changes May 25, 2020
View reviewed changes
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing Refs # to the actual issue number
  • CI failing

@atodorov atodorov mentioned this pull request May 25, 2020
Merged
@mfonism mfonism force-pushed the 2020.05.24/issue/1597/test-add-tag branch from 840acbf to e72fd58 Compare May 28, 2020 19:18
@mfonism mfonism requested a review from atodorov May 28, 2020 21:38
@mfonism mfonism changed the title Add tests for API method tcms.bugs.api.add_tag() Add tests for API method tcms.bugs.api.add_tag(). Refs #1597 May 28, 2020
atodorov
atodorov requested changes May 29, 2020
View reviewed changes
atodorov
atodorov requested changes Jun 3, 2020
View reviewed changes
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on the latest master and use the APIPermissionsTestCase implementation from there. There's also an example how to use it.

@mfonism mfonism force-pushed the 2020.05.24/issue/1597/test-add-tag branch from 7b11ff8 to 711bba2 Compare June 11, 2020 12:13
@mfonism mfonism requested a review from atodorov June 11, 2020 12:32
@mfonism
Copy link
Contributor Author

mfonism commented Jun 11, 2020

@atodorov I've implemented the changes you requested

atodorov
atodorov requested changes Jun 12, 2020
View reviewed changes
@mfonism mfonism force-pushed the 2020.05.24/issue/1597/test-add-tag branch from 711bba2 to 02b067e Compare July 6, 2020 15:07
@mfonism mfonism requested a review from atodorov July 6, 2020 15:16
@mfonism
Copy link
Contributor Author

mfonism commented Jul 6, 2020

@atodorov I've implemented the changes you requested

atodorov
atodorov requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing / without internal bug tracker CI job is failing, needs to be fixed. See how the other test files under tcms/bugs/tests skip the testing if bug tracker is not enabled.

@mfonism mfonism force-pushed the 2020.05.24/issue/1597/test-add-tag branch from 02b067e to b2b39a2 Compare July 9, 2020 10:27
@mfonism mfonism force-pushed the 2020.05.24/issue/1597/test-add-tag branch from b2b39a2 to 6d9f750 Compare July 9, 2020 11:49
@mfonism mfonism requested a review from atodorov July 9, 2020 12:35
@atodorov atodorov merged commit 4d50b1c into kiwitcms:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfonism @atodorov