Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for API method tcms.bugs.api.filter() #1692

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Add tests for API method tcms.bugs.api.filter() #1692

merged 1 commit into from
Jul 13, 2020

Conversation

mfonism
Copy link
Contributor

@mfonism mfonism commented May 25, 2020

This PR adds tests for the filter() api method in tcms/bugs/api.py as per #1597

atodorov
atodorov requested changes May 25, 2020
View reviewed changes
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

  • Add Refs # + the actual issue number in your commit log
  • Make CI pass, see how other test files in this directory are designed.

@mfonism mfonism force-pushed the 2020.05.25/issue/1597/test-filter branch from a1575bf to 610b8d5 Compare July 12, 2020 21:49
@mfonism mfonism requested a review from atodorov July 12, 2020 21:59
atodorov
atodorov requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, minor changes requested.

This is the last PR adding tests for this module so use Closes # in the commit log.

@mfonism mfonism force-pushed the 2020.05.25/issue/1597/test-filter branch 2 times, most recently from 85d3503 to 5271344 Compare July 13, 2020 12:43
@mfonism mfonism requested a review from atodorov July 13, 2020 12:43
@mfonism mfonism force-pushed the 2020.05.25/issue/1597/test-filter branch from 5271344 to cad68bc Compare July 13, 2020 13:09
@mfonism mfonism force-pushed the 2020.05.25/issue/1597/test-filter branch from cad68bc to c68106c Compare July 13, 2020 13:13
@mfonism
Copy link
Contributor Author

mfonism commented Jul 13, 2020

@atodorov I've implemented the changes you requested.

@atodorov atodorov merged commit 736abf0 into kiwitcms:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfonism @atodorov