Redesign TestPlan page UI #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
refactor_testplan_ui
branch
from
7fb7a32 to
dd4d118
Compare
atodorov
force-pushed
the
refactor_testplan_ui
branch
from
9cf025a to
e05e2e0
Compare
also adds a TODO comment for misaligned titles cc @RMadjev
- for now keep constructTagZone() b/c it is called in other JS functions which are obsolete but may still be useful when debugging on the current branch. Will be removed later with everything else related to plan/get.html template - make pylint happier
TODO: the clone view needs refactoring b/c it doesn't accept GET requests
this will be implemented similarly to #1402 for the easier case (adding TC by ID and Summary). For advanced search & add we should reuse the existing test case search functionality. This commit removes all functionality related to these deprecated pages which is not used anywhere else.
- removes testplan_actions.js - lib/tablednd.js - lots of helper & unused functions removed The following views are also removed: - /plan/update-parent/ - /ajax/update/cases-actor/ - /cases/load-more/ - /case/<pk>/readonly-pane/ - testcases.views.list_all()
this should probably be implemented via JSON-RPC API because we've got a request to add the opposite method - reading the sortkey, see In case API isn't feasible this commit can easily be reverted.
not needed anymore b/c the new pages can be styled for print using CSS
- calculate_stats_for_testplans - get_number_of_plans_cases - get_number_of_plans_runs
instead of another conditional
this should ultimately happen for all of the <template> tags so we can visually connect them with the rest of the page. Makes the code easier to look at and doesn't require scrolling up and down.
b/c expansions are cached and we want the UI to be refreshed b/c status controls how/if comment editors are shown
- constructTagZone() - addTag() - removeTag() - json_failure() - html_failure() - splitString() - previewPlan() - clearDialog() - clickedSelectAll() - constructForm()
- Nitrate.TestCases.CasesSelection() - toggleAllCases() - serializeCaseFromInputList2() - serializeCaseFromInputList() - serialzeCaseForm()
b/c the textarea element is statically rendered it will have the same non-unique ID whenever we render each row. This leads to a bug where you can have multiple editors loaded when the first row is an unconfirmed test case b/c their IDs would change only after expanding. Miving the ID change before each row is drawn fixes this problem.
the edit already supports that via ~~text~~ syntax but the Python renderer didn't know about it!
b/c we're not using xml.etree.ElementTree to parse data but to create a new node and insert it into the resulting HTML.
when rendering Markdown into HTML unescape the input b/c it may be coming from another API call and could be preescaped. This is the case for example when adding comments! The BE rendering functionality will take care to remove any characters that are deemed unsafe! If we don't do this then some inputs already contain escaped sequences, e.g. quotes in code blocks which don't appear well when rendered as HTML.
without this commit all internal API calls are executed which isn't necessary
because these are rendered from a <template> tag they end up with the same IDs
also pass the number of disabled test cases to the HTML template. fixes #718
- instead make use of NewRunForm class - swap the order in which form fields are filtered internally inside .populate() so it can work with an int ID parameter instead of an object (for both API and views).
instead of passing each individual value around. Also make sure that the product_version field gets automatically updated based on the value of the chosen test plan!
NOTE: the previous implementation seems to work fine for views and with API calls when executed live. However it causes one test to fail b/c it can't find the 'CONFIRMED' status! This implementation is not the best one but is functionally equivalent and seems to work. Also all of this will be refactored as part of #1932 very soon.
atodorov
force-pushed
the
refactor_testplan_ui
branch
from
528c4a9 to
4d019fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening so we can see the overview of changes and test results in preparation for merging all of these changes.