add test for TestExecution #1625 #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
requested changes
Oct 30, 2020
awalvie
force-pushed
the
test_for_testexecution
branch
from
a17a54e to
42411f5
Compare
atodorov
requested changes
Oct 30, 2020
awalvie
force-pushed
the
test_for_testexecution
branch
from
42411f5 to
90dfa13
Compare
awalvie
force-pushed
the
test_for_testexecution
branch
from
90dfa13 to
17d99e0
Compare
awalvie
changed the title
atodorov
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the test cases for handling the functionality of
TestExecution.remove_commentas that was the only function remaining out of the code coverage. I was having trouble figuring out when and if I have to setup a separate test to check permissions, and needed some clarity regarding it.