Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "page preview" feature of Wikipedia and Wikivoyage #278

Closed
Jaifroid opened this issue Jun 16, 2022 · 1 comment · Fixed by #595
Closed

Support "page preview" feature of Wikipedia and Wikivoyage #278

Jaifroid opened this issue Jun 16, 2022 · 1 comment · Fixed by #595
Assignees
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jun 16, 2022

This is the same as upstream kiwix/kiwix-js#719. I would be happy to work on this upstream, but it might be better to experiment with the feasibility of this feature here, only because I already have the click infrastructure set up, whereas kiwix/kiwix-js#680 failed. Happy to be corrected if this supposition is wrong.

Having said this, the modern way to do this would be to attach the required DOM nodes programmatically only when the user hovers over (or long-presses) a hyperlink. Detection would be done at iframe (or tab/window) level, making this compatible with SW mode -- this is similar to the mechanism used in kiwix/kiwix-js#862.

This ticket is medium-to-long term. I don't have time to work on it right now, but it would be cool. Expected end result is as below. Our simple page extraction is very fast (a few tenths of a second on a good machine and modern browser), and we wouldn't be extracting assets other than one image (also very fast to extract).

image

@Jaifroid Jaifroid added this to the Release 2.1.0 milestone Jun 16, 2022
@Jaifroid Jaifroid self-assigned this Jun 16, 2022
@Jaifroid
Copy link
Member Author

And here is a simple, short CSS file that sets up the balloon. It's pure CSS, which is cool (no JS!):

https://github.com/kazzkiq/balloon.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant