You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the same as upstream kiwix/kiwix-js#719. I would be happy to work on this upstream, but it might be better to experiment with the feasibility of this feature here, only because I already have the click infrastructure set up, whereas kiwix/kiwix-js#680 failed. Happy to be corrected if this supposition is wrong.
Having said this, the modern way to do this would be to attach the required DOM nodes programmatically only when the user hovers over (or long-presses) a hyperlink. Detection would be done at iframe (or tab/window) level, making this compatible with SW mode -- this is similar to the mechanism used in kiwix/kiwix-js#862.
This ticket is medium-to-long term. I don't have time to work on it right now, but it would be cool. Expected end result is as below. Our simple page extraction is very fast (a few tenths of a second on a good machine and modern browser), and we wouldn't be extracting assets other than one image (also very fast to extract).
The text was updated successfully, but these errors were encountered:
This is the same as upstream kiwix/kiwix-js#719. I would be happy to work on this upstream, but it might be better to experiment with the feasibility of this feature here, only because I already have the click infrastructure set up, whereas kiwix/kiwix-js#680 failed. Happy to be corrected if this supposition is wrong.
Having said this, the modern way to do this would be to attach the required DOM nodes programmatically only when the user hovers over (or long-presses) a hyperlink. Detection would be done at iframe (or tab/window) level, making this compatible with SW mode -- this is similar to the mechanism used in kiwix/kiwix-js#862.
This ticket is medium-to-long term. I don't have time to work on it right now, but it would be cool. Expected end result is as below. Our simple page extraction is very fast (a few tenths of a second on a good machine and modern browser), and we wouldn't be extracting assets other than one image (also very fast to extract).
The text was updated successfully, but these errors were encountered: