Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for integrity of gitignore.patch #1085

Closed
Jaifroid opened this issue Aug 31, 2023 · 0 comments · Fixed by #1084
Closed

Add test for integrity of gitignore.patch #1085

Jaifroid opened this issue Aug 31, 2023 · 0 comments · Fixed by #1084
Assignees
@Jaifroid
Labels
build Code relating to building, publishing, or maintaining the app tests
Milestone
v3.10

Comments

@Jaifroid
Copy link
Member

Since we need to patch .gitignore to make node_modules available for testing the unbundled version of the app on our dev implementations (gh-pages), it is a good idea to add a test for the integrity of the patch. Particularly as a corrupt one slipped through in a recent PR.

A PR to address this is #1084.
@Jaifroid Jaifroid added tests build Code relating to building, publishing, or maintaining the app labels Aug 31, 2023
@Jaifroid Jaifroid added this to the v4.0 milestone Aug 31, 2023
@Jaifroid Jaifroid self-assigned this Aug 31, 2023
@Jaifroid Jaifroid mentioned this issue Aug 31, 2023
Merged
@Jaifroid Jaifroid linked a pull request Aug 31, 2023 that will close this issue
Fix corrupt gitignore patch #1084
Merged
Jaifroid added a commit that referenced this issue Aug 31, 2023
@Jaifroid
Add integrity test for gitignore.patch #1085 (#1084)
ed95be5
@Jaifroid Jaifroid modified the milestones: v4.0, v3.10 Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
build Code relating to building, publishing, or maintaining the app tests
Projects
None yet
Milestone
v3.10
Development

Successfully merging a pull request may close this issue.

Fix corrupt gitignore patch kiwix/kiwix-js
1 participant
@Jaifroid