Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading a PhET archive in jQuery mode does not trigger the Active Content Warning #1104

Closed
Jaifroid opened this issue Sep 9, 2023 · 2 comments · Fixed by #1106
Closed

Loading a PhET archive in jQuery mode does not trigger the Active Content Warning #1104

Jaifroid opened this issue Sep 9, 2023 · 2 comments · Fixed by #1106
Assignees
@Jaifroid
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix extensions Code relating to the production or running of browser extensions regression Broken things that used to work
Milestone
v3.10

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Sep 9, 2023

At least for phet_es_2023-01.zim. This is an issue for the Firefox Browser Extension, which thereby doesn't warn users to switch to jQuery mode. It's a regression, I believe and should be fixed before releasing v3.10.0.
@Jaifroid Jaifroid added regression Broken things that used to work bug-non-critical For bugs that it would be nice to fix rather than critical to fix labels Sep 9, 2023
@Jaifroid Jaifroid added this to the v3.10 milestone Sep 9, 2023
@Jaifroid Jaifroid self-assigned this Sep 9, 2023
@Jaifroid
Copy link
Member Author

Jaifroid commented Sep 9, 2023

Confirmed to affect both Firefox and Chromium browser extensions in jQuery mode. Need to test also the latest ZIMs.

@Jaifroid
Copy link
Member Author

Jaifroid commented Sep 9, 2023

Also affects latest available PhET (April 2023). This cannot run in a local Chromium extension either due to its use of unsafe-eval. It can run in the remote extension (PWA). We may need to warn users of this, but it could be tricky to do it generically, so probably a separate issue.

This was referenced Sep 9, 2023
Closed
Merged
@Jaifroid Jaifroid added the extensions Code relating to the production or running of browser extensions label Sep 9, 2023
Jaifroid added a commit that referenced this issue Sep 9, 2023
@Jaifroid
Fix active content warning for PhET ZIMs #1104 (#1106)
3963b88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix extensions Code relating to the production or running of browser extensions regression Broken things that used to work
Projects
None yet
Milestone
v3.10
Development

Successfully merging a pull request may close this issue.

Fix active content warning for PhET ZIMs kiwix/kiwix-js
1 participant
@Jaifroid