Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the behavior and layout of the screen (iframe version), to optimize the available space for article content #120

Closed
mossroy opened this issue Aug 22, 2015 · 6 comments
Assignees
Milestone

Comments

@mossroy
Copy link
Contributor

mossroy commented Aug 22, 2015

The iframe currently takes all the available space (including height).
But the top area always stays visible, and does not let enough space for the article.

IMHO, it would be ideal to implement the same behavior as in the browser of Firefox OS >= 2.1 :

  • when the user scrolls up, the top area shrinks (or even disappears). There are options in jquery hide() function to hide them smoothly, but we also need to resize the iframe at this moment
  • when the user scrolls down, the top area reappears (and the iframe should be resized)
  • the top area also contains the back/forward buttons
  • the bottom bar and buttons become useless and might be removed

... but it might be hard to implement

@mossroy
Copy link
Contributor Author

mossroy commented Aug 23, 2015

Maybe using something like https://medium.com/@mariusc23/hide-header-on-scroll-down-show-on-scroll-up-67bbaae9a78c would do what we need for the header BUT the difficulty will be to expand/reduce the iframe without visibly moving the content inside

@kelson42
Copy link
Collaborator

Yes, would be great to have it that way (it works like this on Kiwix for iOS for example) but I would pospone this after the first release. For example Kiwix for Android has always the top bar visible, ant this is OK, users do not complain too much about it.

@mossroy
Copy link
Contributor Author

mossroy commented Aug 23, 2015

You're right in the sense that we first need a functional application, and we can leave some enhancements for next versions.
But there is still a minimum that needs to be done in any case :

  • reduce the size of top area : the article content is really in a too small area for now
  • make the back/forward/top buttons work again

mossroy added a commit that referenced this issue Aug 29, 2015
These elements stay visible when the article content is scrolled
(because of the iframe).
Reducing their size gives more space to the article content itself
It looks like the bare minimum without implementing #120 (make the top
elements disappear/reappear when the article content is scrolled)
@mossroy
Copy link
Contributor Author

mossroy commented Aug 29, 2015

OK I did what I considered to be the minimum for a first release with the iframe. So I push this enhancement for the following version

@mossroy mossroy modified the milestones: v2.1, v2.0 Aug 29, 2015
@mossroy mossroy modified the milestones: v2.3, v2.2 May 29, 2017
@mossroy mossroy mentioned this issue Jun 24, 2017
@Jaifroid
Copy link
Member

On small screens, at least on Windows Mobile, the top area does disappear when scrolling down the page, so the article becomes fullscreen apart from the very narrow navbar and buttons at the bottom. I think this should be a behaviour based on window size and in particular on pixel height of the window, rather than absolute screensize. Effectively it would be good to have the app/page fully responsive, so that it doesn't matter if it is showing on a 720 x 1024 screen or in a window of 720 x 1024, but it will adopt the same behaviour based on the available display space.

@mossroy mossroy modified the milestones: v3.2, v3.3 Aug 22, 2021
@Jaifroid Jaifroid modified the milestones: v3.3, v3.4 Jan 31, 2022
@Jaifroid
Copy link
Member

This would be superseded by #523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants