-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the behavior and layout of the screen (iframe version), to optimize the available space for article content #120
Comments
Maybe using something like https://medium.com/@mariusc23/hide-header-on-scroll-down-show-on-scroll-up-67bbaae9a78c would do what we need for the header BUT the difficulty will be to expand/reduce the iframe without visibly moving the content inside |
Yes, would be great to have it that way (it works like this on Kiwix for iOS for example) but I would pospone this after the first release. For example Kiwix for Android has always the top bar visible, ant this is OK, users do not complain too much about it. |
You're right in the sense that we first need a functional application, and we can leave some enhancements for next versions.
|
These elements stay visible when the article content is scrolled (because of the iframe). Reducing their size gives more space to the article content itself It looks like the bare minimum without implementing #120 (make the top elements disappear/reappear when the article content is scrolled)
OK I did what I considered to be the minimum for a first release with the iframe. So I push this enhancement for the following version |
On small screens, at least on Windows Mobile, the top area does disappear when scrolling down the page, so the article becomes fullscreen apart from the very narrow navbar and buttons at the bottom. I think this should be a behaviour based on window size and in particular on pixel height of the window, rather than absolute screensize. Effectively it would be good to have the app/page fully responsive, so that it doesn't matter if it is showing on a 720 x 1024 screen or in a window of 720 x 1024, but it will adopt the same behaviour based on the available display space. |
This would be superseded by #523. |
The iframe currently takes all the available space (including height).
But the top area always stays visible, and does not let enough space for the article.
IMHO, it would be ideal to implement the same behavior as in the browser of Firefox OS >= 2.1 :
... but it might be hard to implement
The text was updated successfully, but these errors were encountered: