Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a spinner when the user clicks on a link inside an article (in ServiceWorker mode) #135

Closed
mossroy opened this issue Jan 5, 2016 · 3 comments
Assignees

Comments

@mossroy
Copy link
Contributor

mossroy commented Jan 5, 2016

It can take a few seconds to display the new article : the user needs to have a visual feedback that his click is being processed.

One approach to test is to catch the onclick event on all the iframe, and then find out if the target of this click event is inside a <a href> tag. In this case, the spinner should be visible (and disappear when the new article appears)

@mossroy mossroy self-assigned this Jan 5, 2016
@mossroy mossroy added this to the v2.0 milestone Jan 5, 2016
mossroy added a commit that referenced this issue Jan 8, 2016
So that the user knows his click is being processed.
Fixes #135
@mossroy mossroy modified the milestones: v2.1, v2.0 Apr 29, 2016
@mossroy mossroy modified the milestones: v2.3, v2.2 May 29, 2017
@mossroy mossroy modified the milestones: v2.3, v2.4 Jan 4, 2018
@Jaifroid
Copy link
Member

Jaifroid commented Jun 2, 2018

@mossroy, I was about to open a new issue for this (lack of "Reading article" + spinner when user clicks on a link in Service Worker) when a vague memory of having seen something like it before led me here. So, this is just to report that this (minor) issue is ongoing in Service Worker mode to date (tested today on Chromium). But I would label this a bug rather than an enhancement. Surely the intended behaviour is to give feedback to the user?

@mossroy
Copy link
Contributor Author

mossroy commented Jun 3, 2018

In ServiceWorker mode, I would hope that the browser handles that by itself.
When the user clicks on a link inside the iframe, it should be the same behavior as when you click on a hyperlink in a web page : the browser indicates it is busy until the page is loaded, with indicators like explained here : https://www.stevesouders.com/blog/2013/06/16/browser-busy-indicators/
Obviously, these busy indicators don't show up here : I'd like to understand why, before implementing our own indicators. Maybe there would be a way to enable these built-in indicators, which would be much better.
Is it because we are in a iframe? Because the requests are handled by a ServiceWorker?

@Jaifroid
Copy link
Member

This issue was incidentally solved by #493. The spinner now shows when a user clicks on a link in SW mode. There are aspects that could be made more consistent, but we have #419 for that.

@Jaifroid Jaifroid removed this from the v3.3 milestone Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants