-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a spinner when the user clicks on a link inside an article (in ServiceWorker mode) #135
Comments
So that the user knows his click is being processed. Fixes #135
@mossroy, I was about to open a new issue for this (lack of "Reading article" + spinner when user clicks on a link in Service Worker) when a vague memory of having seen something like it before led me here. So, this is just to report that this (minor) issue is ongoing in Service Worker mode to date (tested today on Chromium). But I would label this a bug rather than an enhancement. Surely the intended behaviour is to give feedback to the user? |
In ServiceWorker mode, I would hope that the browser handles that by itself. |
It can take a few seconds to display the new article : the user needs to have a visual feedback that his click is being processed.
One approach to test is to catch the onclick event on all the iframe, and then find out if the target of this click event is inside a
<a href>
tag. In this case, the spinner should be visible (and disappear when the new article appears)The text was updated successfully, but these errors were encountered: