Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add favicon #401

Closed
practik opened this issue Jul 11, 2018 · 4 comments
Closed

feature request: add favicon #401

practik opened this issue Jul 11, 2018 · 4 comments
Assignees
Milestone

Comments

@practik
Copy link

practik commented Jul 11, 2018

For those of us using kiwix-js on desktop browsers, it would be helpful to have the favicon showing on the Kiwix tab. I know this was mentioned in passing at #280 (comment), but since that issue is really about the window title, I figured the favicon should have its own issue.

Kiwix 2.3.0 on Firefox 61.0.1 on macOS

@mossroy mossroy self-assigned this Jul 12, 2018
@mossroy mossroy added this to the v2.4 milestone Jul 12, 2018
@mossroy
Copy link
Contributor

mossroy commented Jul 12, 2018

That makes sense. It's probably easy to do.
We currently have an obsolete www/favicon.ico file (with an evopedia logo instead of kiwix), that should be removed, and replaced by some HTML link rel="icon" tags in the header of www/index.html, pointing to the existing PNG icons in www/icons

@mossroy
Copy link
Contributor

mossroy commented Jul 12, 2018

It might also be worth adding link rel="apple-touch-icon" tags for Apple devices. And maybe the meta name="msapplication-*" ones plus the browserconfig.xml file?
http://faviconit.com seems to give some templates

@Jaifroid
Copy link
Member

But would Apple devices use this app? Wouldn't they install the Kiwix app from their respective stores? If we are going to be fully inclusive, we would probably need to do everything on this cheat sheet:

https://github.com/audreyr/favicon-cheat-sheet

But it may be over the top!

mossroy added a commit that referenced this issue Jul 12, 2018
And remove obsolete favicon.ico (that was still using an evopedia icon).
Fixes #401
@mossroy
Copy link
Contributor

mossroy commented Jul 12, 2018

This guide handles very old browsers that we do not even support : I agree with you it's no use adding hacks in our code for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants