-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: add favicon #401
Comments
That makes sense. It's probably easy to do. |
It might also be worth adding |
But would Apple devices use this app? Wouldn't they install the Kiwix app from their respective stores? If we are going to be fully inclusive, we would probably need to do everything on this cheat sheet: https://github.com/audreyr/favicon-cheat-sheet But it may be over the top! |
And remove obsolete favicon.ico (that was still using an evopedia icon). Fixes #401
This guide handles very old browsers that we do not even support : I agree with you it's no use adding hacks in our code for them. |
For those of us using kiwix-js on desktop browsers, it would be helpful to have the favicon showing on the Kiwix tab. I know this was mentioned in passing at #280 (comment), but since that issue is really about the window title, I figured the favicon should have its own issue.
Kiwix 2.3.0 on Firefox 61.0.1 on macOS
The text was updated successfully, but these errors were encountered: