-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for opening details sections in jQuery mode #547
Comments
With a user point of view, I tend to agree with you. But I'm not in favor of doing this in kiwix-js. It seems to me that there would be different proposals :
|
I agree it's best to deal with this in the ZIM in the medium term. But the issue as I see it is:
So, while I am happy to report an issue on mwoffliner, my preference would be at least to make the new ZIMs usable until such time as the problem is fixed in mowoffliner. However, I completely understand your perspective. Let me corroborate 2. above and report back. |
So I've now checked this against the very recent |
I have made this comment on mwoffliner. If our issue turns out not to be related to that issue, I'll promote it to a separate issue, but it seemed to be related. |
We may want to reduce the default size of the pop-up once we implement automatic expanding of <details> sections regardless of the iframe size. Relevant: kiwix/kiwix-js#547
@Jaifroid Do we really want to implement this feature in frozen JQuery mode? |
Considering my PR wasn't accepted, and I don't have another solution, I agree this should be closed. |
This is the issue corresponding to #546. The issue is that in jQuery mode, in browsers that support the summary-details tags, details sections in recent ZIMs remain closed (because jQuery mode cannot run JS-in-the-ZIM). See the PR for more info.
The text was updated successfully, but these errors were encountered: