Can Kiwix remember user settings of Dark theme?

[alextooter]

I like the Dark theme in v2.7,it's beautiful.After I close Kiwix page,then reopen it,Kiwix not remember my choose of Dark theme.

Can we store this option in somewhere,don't let me choose everytime?

[Jaifroid]

Hi @alextooter, it should be able to. Which platform are you using, so I can troubleshoot?

[alextooter]

Hi @alextooter, it should be able to. Which platform are you using, so I can trobuleshoot?

I am using macOS 10.15.4,Firefox 74.0.1,kiwix 2.7.0
My way of using kiwix:click the icon on toolbar,kiwix open with light theme,then I choose Dark+invert(wikimedia*),it turn to dark theme.Close this tab,open it,using Light theme again.

[Jaifroid]

OK, thanks, @alextooter . I presume that's in the Firefox extension?

[Jaifroid]

@alextooter I reproduce the bug in Firefox Extension on Windows 10. However, it is not just with this feature, it is with any feature that stores its settings in a cookie. Something must have been deprecated. Very sorry not to have picked this up in testing.

@mossroy can you reproduce? In the Firefox extension, try changing any setting in Config that should persist between tab sessions, and they are lost the next time the Kiwix JS tab is opened.

[Jaifroid]

Proof that cookies are disabled in Firefox browser extension:

In the extension tab devtools type document.cookie="username=John Doe" and then document.cookie Result:

In a normal tab opening file:///.../kiwix-js/www/index.html:

[Jaifroid]

Looking at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_the_Cookies_API, I see we should have a permissions entry in our manifest.json to use the Cookies API in Firefox Extensions:

We don't have this.

[mossroy]

I reproduce this issue with Firefox 74 (on Ubuntu), not on Chromium 80. I also reproduce on Firefox 68.6 ESR (on Windows 8.1).
So this seems to be Firefox-specific.
Adding

"permissions": [
    "tabs",
    "cookies",
    "<all_urls>"
],

in manifest.json does not help : it seems to be a permission to access cookies from other tabs/websites

[Jaifroid]

I suggest a possible solution to this in #613 .

[mossroy]

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1418961#c6 , it seems to be the expected behavior in Firefox extensions :

Cookies are only supported in HTTP documents

So we'll have to find another way to store the user preferences. I'll have a look at #613

[Jaifroid]

OK. It seems this is since 55/56! I guess our users generally didn't change the defaults, then!

[mossroy]

It's not that surprising : in Firefox extension, you can not use SW mode, so this setting can not be changed. And the theme and cache settings are recent. So the only setting that could be affected since a long time is the "Permanently hide active content warning"

[Jaifroid]

@alextooter We are about to merge into master a fix for this issue that works in development testing on Firefox extension and that we very much hope will work in production. Please note that you will have to wait for a new release, which may take some time as we usually accumulate a number of features before making a new release.