-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize title search so that cancelled binary search Promises return at the earliest possible opportunity #637
Comments
So I don't forget, here is a quick summary of what needs to be done following on from #617:
|
If this works, extend the model to #426, which is a very similar case: we should be able to use the same |
This relates to the optimization of #617. Although searches are successfully cancelled when a user starts a new search or exits the search UI, and extraneous results from a cancelled search do not display in the UI, a certain amount of binary search processing still continues from Promises which had been set up very early on in the search process. It should be possible to return a null result, or use
throw
, from those Promises to prevent unnecessary CPU utilization. This has to be done without simply dereferencing parameters and causing potential memory leaks. It is similar to #426, where a fair amount of processing for a previous article continues after a user has navigated away to another article. Similar techniques could be used to solve both situations.#617 (comment) is particularly relevant to understand the issue here.
The text was updated successfully, but these errors were encountered: